Bug 193334 - DeviceID hash salt manager can be NULL
Summary: DeviceID hash salt manager can be NULL
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebRTC (show other bugs)
Version: WebKit Local Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Eric Carlson
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-01-10 13:32 PST by Eric Carlson
Modified: 2019-01-10 16:49 PST (History)
3 users (show)

See Also:

Attachments
Patch (2.30 KB, patch)
2019-01-10 13:38 PST, Eric Carlson 		no flags Details | Formatted Diff | Diff
Patch (9.99 KB, patch)
2019-01-10 15:05 PST, Eric Carlson 		no flags Details | Formatted Diff | Diff
Patch (11.04 KB, patch)
2019-01-10 15:22 PST, Eric Carlson 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Eric Carlson 2019-01-10 13:32:45 PST 
The websiteDataStore.deviceIdHashSaltStorage NULL check in UserMediaPermissionRequestManagerProxy::enumerateMediaDevicesForFrame is in the wrong place.
Comment 1 Eric Carlson 2019-01-10 13:33:11 PST 
<rdar://problem/47179650>
Comment 2 Eric Carlson 2019-01-10 13:38:05 PST 
Created attachment 358825 [details]
Patch
Comment 3 youenn fablet 2019-01-10 13:51:00 PST 
Comment on attachment 358825 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=358825&action=review

> Source/WebKit/UIProcess/UserMediaPermissionRequestManagerProxy.cpp:464
> +            return;

Can we make websiteDataStore return a reference?
Comment 4 Eric Carlson 2019-01-10 15:05:31 PST 
Created attachment 358841 [details]
Patch
Comment 5 youenn fablet 2019-01-10 15:09:17 PST 
Comment on attachment 358841 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=358841&action=review

> Source/WebKit/UIProcess/UserMediaPermissionRequestManagerProxy.cpp:459
> +            return;

Do we need that check here?
Comment 6 Eric Carlson 2019-01-10 15:22:06 PST 
Created attachment 358842 [details]
Patch
Comment 7 Eric Carlson 2019-01-10 15:23:05 PST 
Comment on attachment 358841 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=358841&action=review

>> Source/WebKit/UIProcess/UserMediaPermissionRequestManagerProxy.cpp:459
>> +            return;
> 
> Do we need that check here?

It is inside of an asynchronous completion handler, so I assume it is possible for the page to have been invalidated.
Comment 8 WebKit Commit Bot 2019-01-10 16:49:31 PST 
Comment on attachment 358842 [details]
Patch

Clearing flags on attachment: 358842

Committed r239850: <https://trac.webkit.org/changeset/239850>
Comment 9 WebKit Commit Bot 2019-01-10 16:49:33 PST 
All reviewed patches have been landed.  Closing bug.