Bug 193326 - Remove unneeded XPCService variant for plugin service
Summary: Remove unneeded XPCService variant for plugin service
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Plug-ins (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alexey Proskuryakov
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-01-10 10:33 PST by Alexey Proskuryakov
Modified: 2019-01-10 13:24 PST (History)
5 users (show)

See Also:

Attachments
proposed patch (29.19 KB, patch)
2019-01-10 10:34 PST, Alexey Proskuryakov 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alexey Proskuryakov 2019-01-10 10:33:03 PST 
.
Comment 1 Alexey Proskuryakov 2019-01-10 10:34:56 PST 
Created attachment 358806 [details]
proposed patch
Comment 2 Tim Horton 2019-01-10 12:25:06 PST 
Comment on attachment 358806 [details]
proposed patch

View in context: https://bugs.webkit.org/attachment.cgi?id=358806&action=review

> Source/WebKit/WebKit.xcodeproj/project.pbxproj:4250
> +		BCFCA89516DE96CB00074069 /* PluginService.64.Info.plist */ = {isa = PBXFileReference; lastKnownFileType = text.plist.xml; path = PluginService.64.Info.plist; sourceTree = "<group>"; };

This should all probably just become "PluginService", right?
Comment 3 Alexey Proskuryakov 2019-01-10 12:56:48 PST 
Maybe, but I didn't want to depend on someone somewhere hardcoding the name.
Comment 4 WebKit Commit Bot 2019-01-10 13:23:08 PST 
Comment on attachment 358806 [details]
proposed patch

Clearing flags on attachment: 358806

Committed r239841: <https://trac.webkit.org/changeset/239841>
Comment 5 WebKit Commit Bot 2019-01-10 13:23:09 PST 
All reviewed patches have been landed.  Closing bug.
Comment 6 Radar WebKit Bug Importer 2019-01-10 13:24:28 PST 
<rdar://problem/47188415>