Bug 193324 - [macOS] Add name of IORegistry key in sandbox.
Summary: [macOS] Add name of IORegistry key in sandbox.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Per Arne Vollan
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-01-10 09:44 PST by Per Arne Vollan
Modified: 2019-01-10 10:49 PST (History)
4 users (show)

See Also:


Attachments
Patch (1.43 KB, patch)
2019-01-10 09:48 PST, Per Arne Vollan
no flags Details | Formatted Diff | Diff
Patch (1.44 KB, patch)
2019-01-10 10:04 PST, Per Arne Vollan
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Per Arne Vollan 2019-01-10 09:44:22 PST
IOGVAVTCapabilities key has been changed to IOGVAHEVCDecodeCapabilities.
Comment 1 Brent Fulgham 2019-01-10 09:47:09 PST
We should allow both to support new WebKit on older OS.
Comment 2 Per Arne Vollan 2019-01-10 09:48:48 PST
Created attachment 358801 [details]
Patch
Comment 3 Brent Fulgham 2019-01-10 10:02:21 PST
Comment on attachment 358801 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=358801&action=review

I don't think this is right.

> Source/WebKit/WebProcess/com.apple.WebProcess.sb.in:251
> +    (iokit-property-regex #"^IOGVA(BGRAEnc|Codec|EncoderRestricted|Scaler|HEVCDecodeCapabilities)")

This will cause this to break if someone runs STP on an older OS..

I think this should be:

(iokit-property-regex #"^IOGVA(BGRAEnc|Codec|EncoderRestricted|Scaler|VTCapabilities|HEVCDecodeCapabilities)")
Comment 4 Per Arne Vollan 2019-01-10 10:04:18 PST
Created attachment 358802 [details]
Patch
Comment 5 Per Arne Vollan 2019-01-10 10:05:29 PST
(In reply to Brent Fulgham from comment #3)
> Comment on attachment 358801 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=358801&action=review
> 
> I don't think this is right.
> 
> > Source/WebKit/WebProcess/com.apple.WebProcess.sb.in:251
> > +    (iokit-property-regex #"^IOGVA(BGRAEnc|Codec|EncoderRestricted|Scaler|HEVCDecodeCapabilities)")
> 
> This will cause this to break if someone runs STP on an older OS..
> 
> I think this should be:
> 
> (iokit-property-regex
> #"^IOGVA(BGRAEnc|Codec|EncoderRestricted|Scaler|VTCapabilities|HEVCDecodeCapa
> bilities)")

Ah, right! I have updated the patch. Thanks for reviewing!
Comment 6 Brent Fulgham 2019-01-10 10:08:53 PST
Comment on attachment 358802 [details]
Patch

Looks good!
Comment 7 WebKit Commit Bot 2019-01-10 10:47:50 PST
Comment on attachment 358802 [details]
Patch

Clearing flags on attachment: 358802

Committed r239834: <https://trac.webkit.org/changeset/239834>
Comment 8 WebKit Commit Bot 2019-01-10 10:47:51 PST
All reviewed patches have been landed.  Closing bug.
Comment 9 Radar WebKit Bug Importer 2019-01-10 10:49:29 PST
<rdar://problem/47182898>