Bug 193319 - [WPE] API test gardening
Summary: [WPE] API test gardening
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WPE WebKit (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Charlie Turner
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-01-10 07:19 PST by Charlie Turner
Modified: 2019-02-05 08:03 PST (History)
5 users (show)

See Also:


Attachments
Patch (5.49 KB, patch)
2019-01-10 08:35 PST, Charlie Turner
no flags Details | Formatted Diff | Diff
Patch (4.03 KB, patch)
2019-01-10 12:42 PST, Charlie Turner
no flags Details | Formatted Diff | Diff
Patch for landing (4.06 KB, patch)
2019-01-14 04:02 PST, Charlie Turner
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Charlie Turner 2019-01-10 07:19:25 PST
[WPE] API test gardening
Comment 1 Charlie Turner 2019-01-10 08:35:41 PST
Created attachment 358796 [details]
Patch
Comment 2 Loïc Yhuel 2019-01-10 10:44:29 PST
Comment on attachment 358796 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=358796&action=review

> Tools/TestWebKitAPI/Tests/WTF/StringConcatenate.cpp:85
> +#if PLATFORM(WIN) || U_ICU_VERSION_MAJOR_NUM >= 58

U_ICU_VERSION_MAJOR_NUM >= 59
ICU 58 has the old UChar definition.
Comment 3 Michael Catanzaro 2019-01-10 12:04:43 PST
The ICU change should be split into a different bug.
Comment 4 Charlie Turner 2019-01-10 12:42:25 PST
Created attachment 358819 [details]
Patch

Split the ICU fix into a separate patch, this one now deals only with newly passing API tests on WPE
Comment 5 Charlie Turner 2019-01-10 12:52:44 PST
Please see https://bugs.webkit.org/show_bug.cgi?id=193332 for the ICU stuff splitted out
Comment 6 Charlie Turner 2019-01-14 04:02:43 PST
Created attachment 359028 [details]
Patch for landing
Comment 7 WebKit Commit Bot 2019-01-14 04:41:07 PST
Comment on attachment 359028 [details]
Patch for landing

Clearing flags on attachment: 359028

Committed r239922: <https://trac.webkit.org/changeset/239922>
Comment 8 WebKit Commit Bot 2019-01-14 04:41:09 PST
All reviewed patches have been landed.  Closing bug.