Bug 193309 – Safari Crashing in Version 12.0.1 (14606.2.104.1.1) WebCore::GraphicsLayerCA::updateBackdropFilters

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Dean Jackson]

Safari Crashing in Version 12.0.1 (14606.2.104.1.1) WebCore::GraphicsLayerCA::updateBackdropFilters

[Dean Jackson]

<rdar://problem/45279224>

[Dean Jackson]

Created attachment 358765 [details]
Patch

[Antoine Quint]

Comment on attachment 358765 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=358765&action=review

> Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp:2157
> +        if (backdropFilterRect.width() > 0 && backdropFilterRect.height() > 0) {

Should `canHaveBackdropFilters` be set to true in case either the width or height is 0? Also, do we need the `> 0` check? I assume these values can't be negative.

[Dean Jackson]

Comment on attachment 358765 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=358765&action=review

>> Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp:2157
>> +        if (backdropFilterRect.width() > 0 && backdropFilterRect.height() > 0) {
> 
> Should `canHaveBackdropFilters` be set to true in case either the width or height is 0? Also, do we need the `> 0` check? I assume these values can't be negative.

If either the width or height is 0, then there is no point having a backdrop layer.

Regarding negative, I don't think they ever should be < 0, but it is technically possible... and one of the ways the crash could have happened. I'm hoping to get a reproduction from an originator to see what really went wrong.

[Dean Jackson]

Committed r239833: <https://trac.webkit.org/changeset/239833>