Bug 193303 - Remove the UIProcess components of the ResourceLoadStatistics code
Summary: Remove the UIProcess components of the ResourceLoadStatistics code
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Brent Fulgham
URL:
Keywords: InRadar
Depends on: 193297 193556 193659
Blocks: 193199 193705
  Show dependency tree / graph
 
Reported: 2019-01-09 14:55 PST by Brent Fulgham
Modified: 2019-01-28 11:34 PST (History)
5 users (show)

See Also:

Attachments
Patch (83.24 KB, patch)
2019-01-25 23:09 PST, Brent Fulgham 		cdumez: review+
cdumez: commit-queue-
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Brent Fulgham 2019-01-09 14:55:24 PST 
Once Bug 193297 is landed, we should remove the old UIProcess code that used to do the same work.
Comment 1 Radar WebKit Bug Importer 2019-01-09 14:55:45 PST 
<rdar://problem/47160073>
Comment 2 Brent Fulgham 2019-01-25 23:09:25 PST 
Created attachment 360229 [details]
Patch
Comment 3 Chris Dumez 2019-01-28 08:52:44 PST 
Comment on attachment 360229 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=360229&action=review

r=me

> Source/WebKit/NetworkProcess/Classifier/ResourceLoadStatisticsMemoryStore.cpp:2
> + * Copyright (C) 2017-2019Ã Apple Inc. All rights reserved.

Bad character.
Comment 4 Brent Fulgham 2019-01-28 09:29:51 PST 
Committed r240586: <https://trac.webkit.org/changeset/240586>
Comment 5 Brent Fulgham 2019-01-28 09:30:03 PST 
(In reply to Chris Dumez from comment #3)
> Comment on attachment 360229 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=360229&action=review
> 
> r=me
> 
> > Source/WebKit/NetworkProcess/Classifier/ResourceLoadStatisticsMemoryStore.cpp:2
> > + * Copyright (C) 2017-2019Ã Apple Inc. All rights reserved.
> 
> Bad character.

Fixed while landing.
Comment 6 Alex Christensen 2019-01-28 11:29:13 PST 
Comment on attachment 360229 [details]
Patch

This is the most beautiful patch I've seen in a while.
Comment 7 Brent Fulgham 2019-01-28 11:34:03 PST 
(In reply to Alex Christensen from comment #6)
> Comment on attachment 360229 [details]
> Patch
> 
> This is the most beautiful patch I've seen in a while.

lol. I notice I did manage to get an accidental whitespace change in. :-(