Bug 193300 - Restore bytecode dumper's ability to dump jump target as offset#(->targetBytecodeIndex#).
Summary: Restore bytecode dumper's ability to dump jump target as offset#(->targetByte...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Mark Lam
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-01-09 14:50 PST by Mark Lam
Modified: 2019-01-09 15:05 PST (History)
9 users (show)

See Also:

Attachments
proposed patch. (2.40 KB, patch)
2019-01-09 14:54 PST, Mark Lam 		saam: review+
commit-queue: commit-queue-
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Lam 2019-01-09 14:50:25 PST 
Patch coming.
Comment 1 Mark Lam 2019-01-09 14:54:34 PST 
Created attachment 358748 [details]
proposed patch.
Comment 2 WebKit Commit Bot 2019-01-09 14:58:10 PST 
Comment on attachment 358748 [details]
proposed patch.

Rejecting attachment 358748 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-01', 'validate-changelog', '--check-oops', '--non-interactive', 358748, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

ChangeLog entry in Source/JavaScriptCore/ChangeLog contains OOPS!.

Full output: https://webkit-queues.webkit.org/results/10689205
Comment 3 Mark Lam 2019-01-09 15:04:13 PST 
Thanks for the review.  Landed in r239788: <http://trac.webkit.org/r239788>.
Comment 4 Radar WebKit Bug Importer 2019-01-09 15:05:41 PST 
<rdar://problem/47160435>