Bug 193298 - [WebGPU] Add BindGroupBinding, BindGroupDescriptor, and BufferBinding dictionaries from API
Summary: [WebGPU] Add BindGroupBinding, BindGroupDescriptor, and BufferBinding diction...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Justin Fan
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-01-09 14:35 PST by Justin Fan
Modified: 2019-01-10 11:59 PST (History)
3 users (show)

See Also:


Attachments
Patch (27.92 KB, patch)
2019-01-09 14:43 PST, Justin Fan
no flags Details | Formatted Diff | Diff
Patch (26.53 KB, patch)
2019-01-09 14:51 PST, Justin Fan
no flags Details | Formatted Diff | Diff
Patch for landing (28.24 KB, patch)
2019-01-10 11:01 PST, Justin Fan
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Justin Fan 2019-01-09 14:35:40 PST
[WebGPU] Add BindGroupBinding, BindGroupDescriptor, and BufferBinding dictionaries from API
Comment 1 Justin Fan 2019-01-09 14:43:54 PST
Created attachment 358742 [details]
Patch
Comment 2 Justin Fan 2019-01-09 14:51:09 PST
Created attachment 358745 [details]
Patch
Comment 3 Radar WebKit Bug Importer 2019-01-09 15:22:37 PST
<rdar://problem/47161058>
Comment 4 Dean Jackson 2019-01-09 16:30:33 PST
Comment on attachment 358745 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=358745&action=review

> Source/WebCore/Modules/webgpu/WebGPUBindGroupBinding.h:32
> +#include "WebGPUTextureView.h"
> +

No need for this blank line.

> Source/WebCore/Modules/webgpu/WebGPUBindGroupDescriptor.h:33
> +#include "WebGPUBindGroupLayout.h"
> +
> +#include <wtf/Vector.h>

No need for this blank line.

> Source/WebCore/Modules/webgpu/WebGPUBufferBinding.h:30
> +#include "WebGPUBuffer.h"

I think this file should #include RefPtr.h too.

> Source/WebCore/platform/graphics/gpu/GPUBindGroupBinding.h:33
> +#include "GPUTexture.h"
> +
> +#include <wtf/Variant.h>

No blank line.

> Source/WebCore/platform/graphics/gpu/GPUBindGroupDescriptor.h:33
> +#include "GPUBindGroupLayout.h"
> +
> +#include <wtf/Vector.h>

No blank line. Should probably also include Ref.h
Comment 5 Justin Fan 2019-01-10 11:01:15 PST
Created attachment 358807 [details]
Patch for landing
Comment 6 WebKit Commit Bot 2019-01-10 11:59:24 PST
Comment on attachment 358807 [details]
Patch for landing

Clearing flags on attachment: 358807

Committed r239837: <https://trac.webkit.org/changeset/239837>
Comment 7 WebKit Commit Bot 2019-01-10 11:59:26 PST
All reviewed patches have been landed.  Closing bug.