Bug 193296 - Pipe cache quota request from Network Process to UIProcess
Summary: Pipe cache quota request from Network Process to UIProcess
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Service Workers (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: youenn fablet
URL:
Keywords: InRadar
Depends on:
Blocks: 193323
  Show dependency tree / graph
 
Reported: 2019-01-09 13:55 PST by youenn fablet
Modified: 2019-01-16 17:17 PST (History)
6 users (show)

See Also:

Attachments
Patch (27.34 KB, patch)
2019-01-09 14:37 PST, youenn fablet 		no flags Details | Formatted Diff | Diff
Patch (28.23 KB, patch)
2019-01-09 16:18 PST, youenn fablet 		no flags Details | Formatted Diff | Diff
Patch (28.27 KB, patch)
2019-01-09 16:24 PST, youenn fablet 		no flags Details | Formatted Diff | Diff
Patch (28.82 KB, patch)
2019-01-10 09:04 PST, youenn fablet 		no flags Details | Formatted Diff | Diff
Patch (18.07 KB, patch)
2019-01-16 15:10 PST, youenn fablet 		no flags Details | Formatted Diff | Diff
Show Obsolete (4) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description youenn fablet 2019-01-09 13:55:27 PST 
Pipe cache quota request from Network Process to UIProcess
Comment 1 youenn fablet 2019-01-09 14:37:52 PST 
Created attachment 358740 [details]
Patch
Comment 2 youenn fablet 2019-01-09 16:18:34 PST 
Created attachment 358762 [details]
Patch
Comment 3 youenn fablet 2019-01-09 16:24:47 PST 
Created attachment 358763 [details]
Patch
Comment 4 youenn fablet 2019-01-10 09:04:15 PST 
Created attachment 358800 [details]
Patch
Comment 5 youenn fablet 2019-01-10 11:15:17 PST 
Comment on attachment 358800 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=358800&action=review

> Source/WebKit/NetworkProcess/cache/CacheStorageEngineCaches.h:97
> +    void notifyCachesOfRequestSpaceEnd();

I might use notifyRequestSpaceCompleted instead.
Comment 6 Alex Christensen 2019-01-15 14:11:07 PST 
Comment on attachment 358800 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=358800&action=review

Can we test this?

> Source/WebKit/NetworkProcess/NetworkProcess.cpp:1382
> +    parentProcessConnection()->send(Messages::NetworkProcessProxy::RequestCacheStorageSpace(sessionID, requestIdentifier, origin, quota, currentSize, spaceRequired), 0);

This seems like a prime candidate for sendWithAsyncReply
Comment 7 youenn fablet 2019-01-15 14:17:26 PST 
(In reply to Alex Christensen from comment #6)
> Comment on attachment 358800 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=358800&action=review
> 
> Can we test this?

Not yet, https://bugs.webkit.org/attachment.cgi?id=358810&action=review is adding the test along with the callback to the app.

> 
> > Source/WebKit/NetworkProcess/NetworkProcess.cpp:1382
> > +    parentProcessConnection()->send(Messages::NetworkProcessProxy::RequestCacheStorageSpace(sessionID, requestIdentifier, origin, quota, currentSize, spaceRequired), 0);
> 
> This seems like a prime candidate for sendWithAsyncReply

I can look at that.
Comment 8 youenn fablet 2019-01-16 15:10:49 PST 
Created attachment 359318 [details]
Patch
Comment 9 WebKit Commit Bot 2019-01-16 17:16:13 PST 
Comment on attachment 359318 [details]
Patch

Clearing flags on attachment: 359318

Committed r240099: <https://trac.webkit.org/changeset/240099>
Comment 10 WebKit Commit Bot 2019-01-16 17:16:14 PST 
All reviewed patches have been landed.  Closing bug.
Comment 11 Radar WebKit Bug Importer 2019-01-16 17:17:29 PST 
<rdar://problem/47335783>