Bug 193295 – <video> elements do not enter 'paused' state when playing to end over AirPlay

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Jer Noble]

<video> elements do not enter 'paused' state when playing to end over AirPlay

[Jer Noble]

<rdar://problem/46708670>

[Jer Noble]

Created attachment 358737 [details]
Patch

[EWS Watchlist]

Comment on attachment 358737 [details]
Patch

Attachment 358737 [details] did not pass mac-ews (mac):
Output: https://webkit-queues.webkit.org/results/10688508

Number of test failures exceeded the failure limit.

[EWS Watchlist]

Created attachment 358739 [details]
Archive of layout-test-results from ews103 for mac-sierra

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews103  Port: mac-sierra  Platform: Mac OS X 10.12.6

[EWS Watchlist]

Comment on attachment 358737 [details]
Patch

Attachment 358737 [details] did not pass mac-wk2-ews (mac-wk2):
Output: https://webkit-queues.webkit.org/results/10688517

Number of test failures exceeded the failure limit.

[EWS Watchlist]

Created attachment 358744 [details]
Archive of layout-test-results from ews107 for mac-sierra-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews107  Port: mac-sierra-wk2  Platform: Mac OS X 10.12.6

[EWS Watchlist]

Comment on attachment 358737 [details]
Patch

Attachment 358737 [details] did not pass mac-debug-ews (mac):
Output: https://webkit-queues.webkit.org/results/10688681

Number of test failures exceeded the failure limit.

[EWS Watchlist]

Created attachment 358754 [details]
Archive of layout-test-results from ews115 for mac-sierra

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews115  Port: mac-sierra  Platform: Mac OS X 10.12.6

[Aakash Jain]

This patch seems to cause 31 API Tests Timeout:

https://ews-build.webkit-uat.org/#/builders/19/builds/128

[Eric Carlson]

(In reply to Aakash Jain from comment #9)
> This patch seems to cause 31 API Tests Timeout:
> 
> https://ews-build.webkit-uat.org/#/builders/19/builds/128

And it hasn't landed yet.

[Aakash Jain]

(In reply to Eric Carlson from comment #10)
> And it hasn't landed yet.
Yup. These results are by EWS. We have EWS for API tests coming up soon.

[Jer Noble]

(In reply to Aakash Jain from comment #11)
> (In reply to Eric Carlson from comment #10)
> > And it hasn't landed yet.
> Yup. These results are by EWS. We have EWS for API tests coming up soon.

Nice! (Don't worry; I'm not going to land this patch till the bots are green.)

[Jer Noble]

Created attachment 358835 [details]
Patch for landing

[Eric Carlson]

Comment on attachment 358835 [details]
Patch for landing

View in context: https://bugs.webkit.org/attachment.cgi?id=358835&action=review

> Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:3256
> +void MediaPlayerPrivateAVFoundationObjC::timeControlStatusDidChange(int timeControlStatus)
> +{

Maybe ASSERT(m_shouldObserveTimeControlStatus) ?

[Jer Noble]

(In reply to Eric Carlson from comment #14)
> Comment on attachment 358835 [details]
> Patch for landing
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=358835&action=review
> 
> > Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:3256
> > +void MediaPlayerPrivateAVFoundationObjC::timeControlStatusDidChange(int timeControlStatus)
> > +{
> 
> Maybe ASSERT(m_shouldObserveTimeControlStatus) ?

Can't.  Imagine you ended and immediately seeked; you'd get the KVO delivered while m_shouldObserveTimeControlStatus was set to false.  You could do a 'if (!m_shouldObserve) return;' though.

[Aakash Jain]

> Comment on attachment 358835 [details]
> Patch for landing
Seems like it causes 1 API test failure: TestWebKitAPI.WebKitLegacy.MediaPlaybackSleepAssertion

https://ews-build.webkit-uat.org/#/builders/19/builds/162

[Jer Noble]

Created attachment 358854 [details]
Patch for landing

[Aakash Jain]

> Created attachment 358854 [details]
> Patch for landing
API-tests-macOS passed: https://ews-build.webkit-uat.org/#/builders/19/builds/167

[WebKit Commit Bot]

Comment on attachment 358854 [details]
Patch for landing

Clearing flags on attachment: 358854

Committed r239857: <https://trac.webkit.org/changeset/239857>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.