Bug 193284 - Web Inspector: Protocol Logging: log messages as objects if inspector^2 is open
Summary: Web Inspector: Protocol Logging: log messages as objects if inspector^2 is open
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Devin Rousso
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-01-09 09:20 PST by Devin Rousso
Modified: 2019-01-09 11:39 PST (History)
6 users (show)

See Also:

Attachments
Patch (4.66 KB, patch)
2019-01-09 09:23 PST, Devin Rousso 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Devin Rousso 2019-01-09 09:20:10 PST 
I find that having to sift through the mountain of text that arises from protocol logging inside inspector^2 is a torturous task, so I think it's reasonable to say that if we have a way to display a nicer UI, we should.  If inspector^2 is closed, stringify all messages.  If inspector^2 is open, keep them as JSON objects so they appear all nice and pretty inside inspector^2.
Comment 1 Devin Rousso 2019-01-09 09:23:21 PST 
Created attachment 358710 [details]
Patch
Comment 2 Joseph Pecoraro 2019-01-09 11:09:47 PST 
Comment on attachment 358710 [details]
Patch

r=me
Comment 3 WebKit Commit Bot 2019-01-09 11:38:52 PST 
Comment on attachment 358710 [details]
Patch

Clearing flags on attachment: 358710

Committed r239779: <https://trac.webkit.org/changeset/239779>
Comment 4 WebKit Commit Bot 2019-01-09 11:38:54 PST 
All reviewed patches have been landed.  Closing bug.
Comment 5 Radar WebKit Bug Importer 2019-01-09 11:39:28 PST 
<rdar://problem/47153013>