RESOLVED FIXED 193280
[ews-build] Parse and display number of style failures 
https://bugs.webkit.org/show_bug.cgi?id=193280
Summary [ews-build] Parse and display number of style failures
Aakash Jain
Reported 2019-01-09 07:00:14 PST
Style-EWS should parse the output of check-webkit-style, count the number of failures and include this information in overall build status.
Attachments
Proposed patch (2.83 KB, patch)
2019-01-09 07:03 PST, Aakash Jain 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Aakash Jain
Comment 1 2019-01-09 07:03:48 PST
Created attachment 358701 [details] Proposed patch
Aakash Jain
Comment 2 2019-01-09 07:05:02 PST
Sample run: https://ews-build.webkit-uat.org/#/builders/5/builds/1140
EWS Watchlist
Comment 3 2019-01-09 07:06:58 PST
Attachment 358701 [details] did not pass style-queue: ERROR: Tools/BuildSlaveSupport/ews-build/steps_unittest.py:237: [TestCheckStyle.test_failures_with_style_issues] Passing unexpected keyword argument 'state_string' in function call [pylint/E1123] [5] ERROR: Tools/BuildSlaveSupport/ews-build/steps_unittest.py:237: [TestCheckStyle.test_failures_with_style_issues] No value passed for parameter 'status_text' in function call [pylint/E1120] [5] Total errors found: 2 in 3 files If any of these errors are false positives, please file a bug against check-webkit-style.
WebKit Commit Bot
Comment 4 2019-01-09 13:59:13 PST
Comment on attachment 358701 [details] Proposed patch Clearing flags on attachment: 358701 Committed r239783: <https://trac.webkit.org/changeset/239783>
WebKit Commit Bot
Comment 5 2019-01-09 13:59:14 PST
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 6 2019-01-09 14:00:35 PST
<rdar://problem/47157914>
Note You need to log in before you can comment on or make changes to this bug.