Bug 193261 - Create a WebResourceLoadStatisticsStore attached to the NetworkSession
Summary: Create a WebResourceLoadStatisticsStore attached to the NetworkSession
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Brent Fulgham
URL:
Keywords: InRadar
Depends on:
Blocks: 193199 193297
  Show dependency tree / graph
 
Reported: 2019-01-08 15:23 PST by Brent Fulgham
Modified: 2019-01-09 20:16 PST (History)
5 users (show)

See Also:

Attachments
Patch (40.87 KB, patch)
2019-01-09 14:30 PST, Brent Fulgham 		no flags Details | Formatted Diff | Diff
Patch (43.04 KB, patch)
2019-01-09 14:51 PST, Brent Fulgham 		no flags Details | Formatted Diff | Diff
Patch (43.26 KB, patch)
2019-01-09 16:12 PST, Brent Fulgham 		no flags Details | Formatted Diff | Diff
Patch (42.83 KB, patch)
2019-01-09 17:18 PST, Brent Fulgham 		achristensen: review+
bfulgham: commit-queue+
Details | Formatted Diff | Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Brent Fulgham 2019-01-08 15:23:17 PST 
Each NetworkSession should have a WebResourceLoadStatisticsStore that tracks loads for that session.
Comment 1 Radar WebKit Bug Importer 2019-01-09 14:18:42 PST 
<rdar://problem/47158616>
Comment 2 Brent Fulgham 2019-01-09 14:30:09 PST 
Created attachment 358738 [details]
Patch
Comment 3 Brent Fulgham 2019-01-09 14:51:21 PST 
Created attachment 358746 [details]
Patch
Comment 4 Brent Fulgham 2019-01-09 16:12:42 PST 
Created attachment 358760 [details]
Patch
Comment 5 Brent Fulgham 2019-01-09 17:12:45 PST 
I've got some test crashes. Fixing now and will upload a patch shortly.
Comment 6 Brent Fulgham 2019-01-09 17:18:35 PST 
Created attachment 358769 [details]
Patch
Comment 7 Alex Christensen 2019-01-09 17:19:41 PST 
Comment on attachment 358760 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=358760&action=review

The object ownership model seems good.

> Source/WebKit/ChangeLog:14
> +        WebsiteData object.

WebsiteDataStore

> Source/WebKit/ChangeLog:18
> +        are called in addition the calls to the WebSiteData object. These redundant calls

WebsiteDataStore
Comment 8 Alex Christensen 2019-01-09 18:57:15 PST 
Comment on attachment 358769 [details]
Patch

Interesting.  This makes it so it can exist in either process, with a future patch that will remove its ability to be in the UIProcess.  Cool.
Comment 9 Brent Fulgham 2019-01-09 19:28:57 PST 
Committed r239816: <https://trac.webkit.org/changeset/239816>
Comment 10 Brent Fulgham 2019-01-09 20:16:02 PST 
Follow-up build fix landed:
Committed r239817: <https://trac.webkit.org/changeset/239817>