RESOLVED FIXED 193252
Move ResourceLoadStatistics files from UIProcess to NetworkProcess 
https://bugs.webkit.org/show_bug.cgi?id=193252
Summary Move ResourceLoadStatistics files from UIProcess to NetworkProcess
Brent Fulgham
Reported 2019-01-08 13:02:42 PST
This patch is the first part of a refactoring to move the ResourceLoadStatistics logic from the UIProcess to the NetworkProcess. This patch moves code into different folders and adjusts necessary build files, but does not change where the code executes. A few files were modified to add include files that were needed after these moves, due to vagaries of the unified build system.
Attachments
Patch (342.63 KB, patch)
2019-01-08 13:11 PST, Brent Fulgham 		no flags
DetailsFormatted DiffDiff
Patch for landing (342.81 KB, patch)
2019-01-08 13:25 PST, Brent Fulgham 		no flags
DetailsFormatted DiffDiff
Patch for landing (343.41 KB, patch)
2019-01-08 13:35 PST, Brent Fulgham 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2019-01-08 13:04:31 PST
<rdar://problem/47125401>
Brent Fulgham
Comment 2 2019-01-08 13:11:27 PST
Created attachment 358627 [details] Patch
EWS Watchlist
Comment 3 2019-01-08 13:15:13 PST
Attachment 358627 [details] did not pass style-queue: ERROR: Source/WebKit/NetworkProcess/Classifier/WebResourceLoadStatisticsStore.cpp:219: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit/NetworkProcess/Classifier/WebResourceLoadStatisticsStore.cpp:444: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit/NetworkProcess/Classifier/WebResourceLoadStatisticsStore.cpp:521: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit/NetworkProcess/Classifier/WebResourceLoadStatisticsStore.cpp:567: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit/NetworkProcess/Classifier/WebResourceLoadStatisticsStore.cpp:579: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit/NetworkProcess/Classifier/WebResourceLoadStatisticsStore.cpp:620: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit/NetworkProcess/Classifier/ResourceLoadStatisticsMemoryStore.cpp:414: An else if statement should be written as an if statement when the prior "if" concludes with a return, break, continue or goto statement. [readability/control_flow] [4] Total errors found: 7 in 25 files If any of these errors are false positives, please file a bug against check-webkit-style.
Brent Fulgham
Comment 4 2019-01-08 13:25:32 PST
Created attachment 358629 [details] Patch for landing
EWS Watchlist
Comment 5 2019-01-08 13:30:40 PST
Attachment 358629 [details] did not pass style-queue: ERROR: Source/WebKit/NetworkProcess/Classifier/WebResourceLoadStatisticsStore.cpp:219: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit/NetworkProcess/Classifier/WebResourceLoadStatisticsStore.cpp:444: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit/NetworkProcess/Classifier/WebResourceLoadStatisticsStore.cpp:521: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit/NetworkProcess/Classifier/WebResourceLoadStatisticsStore.cpp:567: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit/NetworkProcess/Classifier/WebResourceLoadStatisticsStore.cpp:579: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit/NetworkProcess/Classifier/WebResourceLoadStatisticsStore.cpp:620: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit/NetworkProcess/Classifier/ResourceLoadStatisticsMemoryStore.cpp:411: An else if statement should be written as an if statement when the prior "if" concludes with a return, break, continue or goto statement. [readability/control_flow] [4] Total errors found: 7 in 25 files If any of these errors are false positives, please file a bug against check-webkit-style.
Brent Fulgham
Comment 6 2019-01-08 13:35:49 PST
Created attachment 358632 [details] Patch for landing
EWS Watchlist
Comment 7 2019-01-08 13:38:09 PST
Attachment 358632 [details] did not pass style-queue: ERROR: Source/WebKit/NetworkProcess/Classifier/WebResourceLoadStatisticsStore.cpp:219: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit/NetworkProcess/Classifier/WebResourceLoadStatisticsStore.cpp:444: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit/NetworkProcess/Classifier/WebResourceLoadStatisticsStore.cpp:521: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit/NetworkProcess/Classifier/WebResourceLoadStatisticsStore.cpp:567: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit/NetworkProcess/Classifier/WebResourceLoadStatisticsStore.cpp:579: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit/NetworkProcess/Classifier/WebResourceLoadStatisticsStore.cpp:620: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit/NetworkProcess/Classifier/ResourceLoadStatisticsMemoryStore.cpp:411: An else if statement should be written as an if statement when the prior "if" concludes with a return, break, continue or goto statement. [readability/control_flow] [4] Total errors found: 7 in 26 files If any of these errors are false positives, please file a bug against check-webkit-style.
WebKit Commit Bot
Comment 8 2019-01-08 14:02:26 PST
Comment on attachment 358632 [details] Patch for landing Clearing flags on attachment: 358632 Committed r239747: <https://trac.webkit.org/changeset/239747>
WebKit Commit Bot
Comment 9 2019-01-08 14:02:27 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.