The layout test editing/selection/ios/show-selection-in-empty-overflow-hidden-document.html occasionally times out in internal automation.
I can reproduce this timeout locally once every 100-or-so runs (using --repeat-each).
From logging captured during one of these failures, it looks like we're sending the right information (i.e. caret rect) to the UI process and then telling our text interaction assistant to re-layout its subviews, but for some reason the caret view doesn't appear in the view hierarchy after all this.
...as it turns out, I did *not* intend for runTest() to be invoked twice in this layout test 🤦🏻♂️ addEventListener("load", runTest); jsTestIsAsync = true; … async function runTest() { … } </script> </head> <body> … <iframe id="frame" srcdoc="<textarea id='editor'></textarea>" onload="runTest()"> Removing the redundant onload="runTest()" from the iframe element fixes the flakiness for me locally.
Created attachment 358669 [details] Patch
Comment on attachment 358669 [details] Patch Thanks for the review!
Comment on attachment 358669 [details] Patch Clearing flags on attachment: 358669 Committed r239771: <https://trac.webkit.org/changeset/239771>
All reviewed patches have been landed. Closing bug.
<rdar://problem/47146052>