RESOLVED FIXED 193238
[iOS] editing/selection/ios/show-selection-in-empty-overflow-hidden-document.html often times out in internal automation 
https://bugs.webkit.org/show_bug.cgi?id=193238
Summary [iOS] editing/selection/ios/show-selection-in-empty-overflow-hidden-document....
Wenson Hsieh
Reported 2019-01-08 08:25:12 PST
The layout test editing/selection/ios/show-selection-in-empty-overflow-hidden-document.html occasionally times out in internal automation.
Attachments
Patch (1.90 KB, patch)
2019-01-08 21:04 PST, Wenson Hsieh 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Wenson Hsieh
Comment 1 2019-01-08 15:15:25 PST
I can reproduce this timeout locally once every 100-or-so runs (using --repeat-each).
Wenson Hsieh
Comment 2 2019-01-08 16:07:24 PST
From logging captured during one of these failures, it looks like we're sending the right information (i.e. caret rect) to the UI process and then telling our text interaction assistant to re-layout its subviews, but for some reason the caret view doesn't appear in the view hierarchy after all this.
Wenson Hsieh
Comment 3 2019-01-08 20:59:51 PST
...as it turns out, I did *not* intend for runTest() to be invoked twice in this layout test 🤦🏻‍♂️ addEventListener("load", runTest); jsTestIsAsync = true; … async function runTest() { … } </script> </head> <body> … <iframe id="frame" srcdoc="<textarea id='editor'></textarea>" onload="runTest()"> Removing the redundant onload="runTest()" from the iframe element fixes the flakiness for me locally.
Wenson Hsieh
Comment 4 2019-01-08 21:04:26 PST
Created attachment 358669 [details] Patch
Wenson Hsieh
Comment 5 2019-01-09 06:58:35 PST
Comment on attachment 358669 [details] Patch Thanks for the review!
WebKit Commit Bot
Comment 6 2019-01-09 07:24:44 PST
Comment on attachment 358669 [details] Patch Clearing flags on attachment: 358669 Committed r239771: <https://trac.webkit.org/changeset/239771>
WebKit Commit Bot
Comment 7 2019-01-09 07:24:45 PST
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 8 2019-01-09 07:25:28 PST
<rdar://problem/47146052>
Note You need to log in before you can comment on or make changes to this bug.