Stop using NetworkStorageSession in WebProcess
Created attachment 358591 [details] Patch
Attachment 358591 [details] did not pass style-queue: ERROR: Source/WebKitLegacy/mac/WebView/WebView.mm:3671: The parameter name "storageSession" adds no information, so it should be removed. [readability/parameter_name] [5] Total errors found: 1 in 12 files If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 358596 [details] Patch
Attachment 358596 [details] did not pass style-queue: ERROR: Source/WebKitLegacy/mac/WebView/WebView.mm:3671: The parameter name "storageSession" adds no information, so it should be removed. [readability/parameter_name] [5] Total errors found: 1 in 15 files If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 358602 [details] Patch
Any other ports require any work for this?
(In reply to Don Olmstead from comment #6) > Any other ports require any work for this? I believe I already did this work for them.
http://trac.webkit.org/r239727
<rdar://problem/47118630>
Rolled out in http://trac.webkit.org/r239735
Comment on attachment 358602 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=358602&action=review > Source/WebCore/loader/CookieJar.cpp:57 > - return context ? context->storageSession() : NetworkStorageSession::defaultStorageSession(); > + return context ? *context->storageSession() : NetworkStorageSession::defaultStorageSession(); This was causing crashes like this: Exception Type: EXC_BAD_ACCESS (SIGSEGV) Exception Codes: KERN_INVALID_ADDRESS at 0x0000000000000000 Exception Note: EXC_CORPSE_NOTIFY Termination Signal: Segmentation fault: 11 Termination Reason: Namespace SIGNAL, Code 0xb Terminating Process: exc handler [54915] VM Regions Near 0: --> __TEXT 0000000104339000-000000010433c000 [ 12K] r-x/rwx SM=COW /Users/USER/*/WebKit.framework/Versions/A/XPCServices/com.apple.WebKit.WebContent.xpc/Contents/MacOS/com.apple.WebKit.WebContent.Development Thread 0 Crashed:: Dispatch queue: com.apple.main-thread 0 com.apple.WebKit 0x0000000230294cfc WebCore::NetworkStorageSession::sessionID() const + 12 (NetworkStorageSession.h:87) 1 com.apple.WebKit 0x0000000230ee1d3b WebKit::WebPlatformStrategies::setCookiesFromDOM(WebCore::NetworkStorageSession const&, WTF::URL const&, WebCore::SameSiteInfo const&, WTF::URL const&, WTF::Optional<unsigned long long>, WTF::Optional<unsigned long long>, WTF::String const&) + 91 (WebPlatformStrategies.cpp:122) 2 com.apple.WebKit 0x0000000230ee1f4f non-virtual thunk to WebKit::WebPlatformStrategies::setCookiesFromDOM(WebCore::NetworkStorageSession const&, WTF::URL const&, WebCore::SameSiteInfo const&, WTF::URL const&, WTF::Optional<unsigned long long>, WTF::Optional<unsigned long long>, WTF::String const&) + 95 3 com.apple.WebCore 0x000000023a53227c WebCore::setCookies(WebCore::Document&, WTF::URL const&, WTF::String const&) + 300 (CookieJar.cpp:112) 4 com.apple.WebCore 0x0000000239c75365 WebCore::Document::setCookie(WTF::String const&) + 405 (Document.cpp:4801) 5 com.apple.WebCore 0x00000002382a21ce WebCore::setJSDocumentCookieSetter(JSC::ExecState&, WebCore::JSDocument&, JSC::JSValue, JSC::ThrowScope&)::'lambda'()::operator()() const + 62 (JSDocument.cpp:1357)
Created attachment 358623 [details] Patch
http://trac.webkit.org/r239737
This caused https://bugs.webkit.org/show_bug.cgi?id=193307