Bug 193227 – Web Inspector: Audit: provide a way to get related Accessibility properties for a given node

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector

[Devin Rousso]

This corresponds to the following `DOM.AccessibilityProperties` properties:
 - busy
 - checked
 - current
 - disabled
 - expanded
 - focused
 - headingLevel
 - hidden
 - hierarchyLevel
 - ignored
 - ignoredByDefault
 - invalid
 - isPopUpButton
 - label
 - liveRegionAtomic
 - liveRegionRelevant
 - liveRegionStatus
 - pressed
 - readonly
 - required
 - role
 - selected

[Devin Rousso]

<rdar://problem/46787862>

[Devin Rousso]

Created attachment 358569 [details]
Patch

Will write tests later, once I have had a chance to look more into the other inspector accessibility tests.

[Devin Rousso]

Created attachment 358853 [details]
Patch

[Joseph Pecoraro]

Comment on attachment 358853 [details]
Patch

r-, this one needs some kind of test (even if it is not exhaustive but at least tests the code path. Otherwise this seems good.

[Devin Rousso]

Created attachment 359775 [details]
Patch

[Joseph Pecoraro]

Comment on attachment 359775 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=359775&action=review

r=me

> LayoutTests/inspector/audit/run-accessibility.html:21
> +        return JSON.stringify(mapped);

You could prettyify this `JSON.stringify(mapped, null, 4)` which would make failure diffs easy to understand if a single property changed.

[Devin Rousso]

Created attachment 359783 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 359783 [details]
Patch

Clearing flags on attachment: 359783

Committed r240309: <https://trac.webkit.org/changeset/240309>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.