Cannot scoll for 5 seconds after swiping back on quoteunquoteapps.com because the gesture snapshot is not promptly taken down.
<rdar://problem/45108222>
<rdar://problem/47096652>
Created attachment 358536 [details] Patch
Attachment 358536 [details] did not pass style-queue: ERROR: Source/WebKit/UIProcess/ios/ViewGestureControllerIOS.mm:293: 'webPageProxyForBackForwardListForCurrentSwipe' is incorrectly named. It should be named 'protector' or 'protectedWebPageProxyForBackForwardListForCurrentSwipe'. [readability/naming/protected] [4] Total errors found: 1 in 5 files If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 358536 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=358536&action=review > Source/WebKit/Shared/WebBackForwardListItem.cpp:147 > + // The following logic must be kept in sync with WebCore::HistoryItem::itemsAreClones(). HistoryItem::itemsAreClones() doesn't have any such comment so this seems guaranteed to bit-rot.
Created attachment 358547 [details] Patch
Attachment 358547 [details] did not pass style-queue: ERROR: Source/WebKit/UIProcess/ios/ViewGestureControllerIOS.mm:293: 'webPageProxyForBackForwardListForCurrentSwipe' is incorrectly named. It should be named 'protector' or 'protectedWebPageProxyForBackForwardListForCurrentSwipe'. [readability/naming/protected] [4] Total errors found: 1 in 7 files If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 358547 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=358547&action=review > Source/WebKit/UIProcess/ios/ViewGestureControllerIOS.mm:291 > + if (areItemsClones) { Why isn't this down after we do all the "good path" things, and just do removeSwipeSnapshot() and return in this block, like the !m_webPageProxy.drawingArea() case?
Comment on attachment 358547 [details] Patch Attachment 358547 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: https://webkit-queues.webkit.org/results/10665131 New failing tests: media/video-zoom.html
Created attachment 358563 [details] Archive of layout-test-results from ews121 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews121 Port: ios-simulator-wk2 Platform: Mac OS X 10.13.6
Created attachment 358567 [details] Patch
Comment on attachment 358567 [details] Patch Clearing flags on attachment: 358567 Committed r239720: <https://trac.webkit.org/changeset/239720>
All reviewed patches have been landed. Closing bug.
I wonder if something similar is happening on GitHub.com pages. For example, go to https://github.com/WebKit/webkit, click on any of the files or folders in the source browser, and then swipe to go back. When I do this, I can't interact with the page for several seconds after swiping to go back. I can interact with the page immediately if I use the back button. However, I tried with STP release 74, and I still see the same issue, so there may be a different cause.
You're right, there's still an issue on Github pages.