Bug 193207 - Remove use of NetworkProcess::singleton for downloads
Summary: Remove use of NetworkProcess::singleton for downloads
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alex Christensen
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-01-07 13:45 PST by Alex Christensen
Modified: 2019-01-07 14:30 PST (History)
2 users (show)

See Also:

Attachments
Patch (13.23 KB, patch)
2019-01-07 13:45 PST, Alex Christensen 		beidson: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alex Christensen 2019-01-07 13:45:14 PST 
Remove use of NetworkProcess::singleton for downloads
Comment 1 Alex Christensen 2019-01-07 13:45:54 PST 
Created attachment 358524 [details]
Patch
Comment 2 Brady Eidson 2019-01-07 14:24:37 PST 
Comment on attachment 358524 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=358524&action=review

> Source/WebKit/NetworkProcess/Downloads/PendingDownload.h:51
> +    PendingDownload(IPC::Connection*, NetworkLoadParameters&&, DownloadID, NetworkSession&, const String& suggestedName);
> +    PendingDownload(IPC::Connection*, std::unique_ptr<NetworkLoad>&&, ResponseCompletionHandler&&, DownloadID, const WebCore::ResourceRequest&, const WebCore::ResourceResponse&);

Sure wish we could make these take Connection&
Comment 3 Alex Christensen 2019-01-07 14:29:37 PST 
Wouldn't it be great?
http://trac.webkit.org/r239699
Comment 4 Radar WebKit Bug Importer 2019-01-07 14:30:30 PST 
<rdar://problem/47096626>