Bug 193175 - API test broken: TestWebKitAPI.WebKit.CustomDataStorePathsVersusCompletionHandlers
Summary: API test broken: TestWebKitAPI.WebKit.CustomDataStorePathsVersusCompletionHan...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: youenn fablet
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-01-06 06:15 PST by Aakash Jain
Modified: 2019-01-07 09:14 PST (History)
9 users (show)

See Also:


Attachments
Patch (10.70 KB, patch)
2019-01-06 11:19 PST, youenn fablet
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Aakash Jain 2019-01-06 06:15:57 PST
This API test seems to be broken recently TestWebKitAPI.WebKit.CustomDataStorePathsVersusCompletionHandlers

API test in https://ews-build.webkit-uat.org/#/builders/19/builds/60 started failing, while it was passing earlier. This API-test build was triggered by https://ews-build.webkit-uat.org/#/builders/25/builds/745 at which time ToT was at 4817fbafca3 Service Worker fetch should obey its referrer policy https://bugs.webkit.org/show_bug.cgi?id=193152

Seems like https://bugs.webkit.org/show_bug.cgi?id=193152 (r239659) might have broken this API test.
Comment 1 Aakash Jain 2019-01-06 06:17:44 PST
build.webkit.org also points to the same commit r239659.

Failing build:
https://build.webkit.org/builders/Apple%20High%20Sierra%20Debug%20WK2%20%28Tests%29/builds/6101

Passing build:
https://build.webkit.org/builders/Apple%20High%20Sierra%20Debug%20WK2%20%28Tests%29/builds/6100

Build 6101 built commit r239659, and this API test started failing.
Comment 2 youenn fablet 2019-01-06 11:03:18 PST
This API test is indeed broken since:
- It copies the SW database to the previous path (-3.sqlite3 instead of -4.sqlite3)
- It uses a SW database with the previous schema
Comment 3 youenn fablet 2019-01-06 11:19:01 PST
Created attachment 358464 [details]
Patch
Comment 4 WebKit Commit Bot 2019-01-07 09:06:33 PST
Comment on attachment 358464 [details]
Patch

Clearing flags on attachment: 358464

Committed r239676: <https://trac.webkit.org/changeset/239676>
Comment 5 WebKit Commit Bot 2019-01-07 09:06:35 PST
All reviewed patches have been landed.  Closing bug.
Comment 6 Radar WebKit Bug Importer 2019-01-07 09:14:36 PST
<rdar://problem/47086545>