Bug 193172 – Incorrect clipping across compositing boundary.

• Status: RESOLVED
• Resolution: FIXED
• Component: Layout and Rendering

[zalan]

rdar://problem/44693008

[zalan]

Created attachment 358443 [details]
Patch

[Simon Fraser (smfr)]

Comment on attachment 358443 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=358443&action=review

> Source/WebCore/ChangeLog:12
> +        clip rect update using the wrong painting root. This happens when the layer hierarchy and the compositing contex do not match.

contex

> Source/WebCore/rendering/RenderLayer.cpp:5486
> +        auto paginationBoundary = parent()->enclosingPaginationLayer(IncludeCompositedPaginatedLayers) != enclosingPaginationLayer(IncludeCompositedPaginatedLayers);
> +        auto compositionBoundaryForRepaint = parent()->enclosingCompositingLayerForRepaint() != enclosingCompositingLayerForRepaint();

I hate auto for primitive types like bool. It doesn't save typing, and it's very unlikely that you'd ever refactor and change the type to get the benefit of auto.

Here, reading "auto paginationBoundary" makes me think that there's some complex "boundary" type I have to go look for.

These bools would read better as crossesPaginationBoundary, crossesCompositingBoundary.

[zalan]

Created attachment 358444 [details]
Patch

[EWS Watchlist]

Comment on attachment 358444 [details]
Patch

Attachment 358444 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: https://webkit-queues.webkit.org/results/10644279

New failing tests:
compositing/clipping/cached-cliprect-with-compositing-boundary.html

[EWS Watchlist]

Created attachment 358448 [details]
Archive of layout-test-results from ews122 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews122  Port: ios-simulator-wk2  Platform: Mac OS X 10.13.6

[zalan]

(In reply to Build Bot from comment #4)
> Comment on attachment 358444 [details]
> Patch
> 
> Attachment 358444 [details] did not pass ios-sim-ews (ios-simulator-wk2):
> Output: https://webkit-queues.webkit.org/results/10644279
> 
> New failing tests:
> compositing/clipping/cached-cliprect-with-compositing-boundary.html

Seriously? The bottom right corner of the iframe's inset border is different.

[zalan]

Created attachment 358449 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 358449 [details]
Patch

Clearing flags on attachment: 358449

Committed r239661: <https://trac.webkit.org/changeset/239661>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.