Created attachment 358443 [details]
Comment on attachment 358443 [details]
View in context: https://bugs.webkit.org/attachment.cgi?id=358443&action=review
> + clip rect update using the wrong painting root. This happens when the layer hierarchy and the compositing contex do not match.
> + auto paginationBoundary = parent()->enclosingPaginationLayer(IncludeCompositedPaginatedLayers) != enclosingPaginationLayer(IncludeCompositedPaginatedLayers);
> + auto compositionBoundaryForRepaint = parent()->enclosingCompositingLayerForRepaint() != enclosingCompositingLayerForRepaint();
I hate auto for primitive types like bool. It doesn't save typing, and it's very unlikely that you'd ever refactor and change the type to get the benefit of auto.
Here, reading "auto paginationBoundary" makes me think that there's some complex "boundary" type I have to go look for.
These bools would read better as crossesPaginationBoundary, crossesCompositingBoundary.
Created attachment 358444 [details]
Comment on attachment 358444 [details]
Attachment 358444 [details] did not pass ios-sim-ews (ios-simulator-wk2):
New failing tests:
Created attachment 358448 [details]
Archive of layout-test-results from ews122 for ios-simulator-wk2
The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews122 Port: ios-simulator-wk2 Platform: Mac OS X 10.13.6
(In reply to Build Bot from comment #4)
> Comment on attachment 358444 [details]
> Attachment 358444 [details] did not pass ios-sim-ews (ios-simulator-wk2):
> Output: https://webkit-queues.webkit.org/results/10644279
> New failing tests:
Seriously? The bottom right corner of the iframe's inset border is different.
Created attachment 358449 [details]
Comment on attachment 358449 [details]
Clearing flags on attachment: 358449
Committed r239661: <https://trac.webkit.org/changeset/239661>
All reviewed patches have been landed. Closing bug.