Bug 193170 - PlatformECKey should use a std::unique_ptr
Summary: PlatformECKey should use a std::unique_ptr
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: WebKit Local Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: David Kilzer (:ddkilzer)
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-01-05 04:01 PST by David Kilzer (:ddkilzer)
Modified: 2019-01-07 12:30 PST (History)
8 users (show)

See Also:

Attachments
Patch v1 (22.03 KB, patch)
2019-01-05 04:05 PST, David Kilzer (:ddkilzer) 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description David Kilzer (:ddkilzer) 2019-01-05 04:01:22 PST 
PlatformECKey should use a std::unique_ptr.

Although there are no known leaks of PlatformECKey, keeping it in a std::unique_ptr makes it much harder to leak by accident.

This change is very similar to Bug 193154 which changed PlatformRSAKey to use a std::unique_ptr.
Comment 1 David Kilzer (:ddkilzer) 2019-01-05 04:05:56 PST 
Created attachment 358436 [details]
Patch v1
Comment 2 Radar WebKit Bug Importer 2019-01-06 02:53:26 PST 
<rdar://problem/47070633>
Comment 3 WebKit Commit Bot 2019-01-07 12:30:19 PST 
Comment on attachment 358436 [details]
Patch v1

Clearing flags on attachment: 358436

Committed r239692: <https://trac.webkit.org/changeset/239692>
Comment 4 WebKit Commit Bot 2019-01-07 12:30:21 PST 
All reviewed patches have been landed.  Closing bug.