Bug 193164 – Modernize CacheModel and disk cache fetching and clearing

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Alex Christensen]

Modernize CacheModel and disk cache fetching and clearing

[Alex Christensen]

Created attachment 358401 [details]
Patch

[Alex Christensen]

Created attachment 358412 [details]
Patch

[EWS Watchlist]

Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API

[Joseph Pecoraro]

Comment on attachment 358412 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=358412&action=review

r=me, but it looks like 1 important issue to fix

> Source/WebKit/NetworkProcess/NetworkProcess.cpp:577
> +    auto* cache = NetworkProcess::singleton().cache();
> +    if (!cache) {
> +        RunLoop::main().dispatch([completionHandler = WTFMove(completionHandler)] () mutable {
> +            completionHandler({ });
> +        });
> +    }

You will need to return here or else you will crash by dereferencing `cache` later on.

[EWS Watchlist]

Comment on attachment 358412 [details]
Patch

Attachment 358412 [details] did not pass mac-ews (mac):
Output: https://webkit-queues.webkit.org/results/10636061

New failing tests:
http/wpt/css/css-animations/start-animation-001.html

[EWS Watchlist]

Created attachment 358423 [details]
Archive of layout-test-results from ews100 for mac-sierra

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews100  Port: mac-sierra  Platform: Mac OS X 10.12.6

[Alex Christensen]

http://trac.webkit.org/r239671

[Radar WebKit Bug Importer]

<rdar://problem/47083208>