Bug 193164 - Modernize CacheModel and disk cache fetching and clearing
Summary: Modernize CacheModel and disk cache fetching and clearing
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alex Christensen
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-01-04 17:02 PST by Alex Christensen
Modified: 2019-01-07 05:58 PST (History)
10 users (show)

See Also:


Attachments
Patch (24.34 KB, patch)
2019-01-04 17:03 PST, Alex Christensen
no flags Details | Formatted Diff | Diff
Patch (29.40 KB, patch)
2019-01-04 18:15 PST, Alex Christensen
joepeck: review+
joepeck: commit-queue-
Details | Formatted Diff | Diff
Archive of layout-test-results from ews100 for mac-sierra (2.45 MB, application/zip)
2019-01-04 19:19 PST, EWS Watchlist
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Alex Christensen 2019-01-04 17:02:25 PST
Modernize CacheModel and disk cache fetching and clearing
Comment 1 Alex Christensen 2019-01-04 17:03:30 PST
Created attachment 358401 [details]
Patch
Comment 2 Alex Christensen 2019-01-04 18:15:40 PST
Created attachment 358412 [details]
Patch
Comment 3 EWS Watchlist 2019-01-04 18:18:14 PST
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API
Comment 4 Joseph Pecoraro 2019-01-04 18:18:53 PST
Comment on attachment 358412 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=358412&action=review

r=me, but it looks like 1 important issue to fix

> Source/WebKit/NetworkProcess/NetworkProcess.cpp:577
> +    auto* cache = NetworkProcess::singleton().cache();
> +    if (!cache) {
> +        RunLoop::main().dispatch([completionHandler = WTFMove(completionHandler)] () mutable {
> +            completionHandler({ });
> +        });
> +    }

You will need to return here or else you will crash by dereferencing `cache` later on.
Comment 5 EWS Watchlist 2019-01-04 19:19:15 PST
Comment on attachment 358412 [details]
Patch

Attachment 358412 [details] did not pass mac-ews (mac):
Output: https://webkit-queues.webkit.org/results/10636061

New failing tests:
http/wpt/css/css-animations/start-animation-001.html
Comment 6 EWS Watchlist 2019-01-04 19:19:16 PST
Created attachment 358423 [details]
Archive of layout-test-results from ews100 for mac-sierra

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews100  Port: mac-sierra  Platform: Mac OS X 10.12.6
Comment 7 Alex Christensen 2019-01-07 05:57:05 PST
http://trac.webkit.org/r239671
Comment 8 Radar WebKit Bug Importer 2019-01-07 05:58:47 PST
<rdar://problem/47083208>