Bug 193163 - Web Inspector: Always buffer some console messages without requiring developerExtrasEnabled be enabled at log time
Summary: Web Inspector: Always buffer some console messages without requiring develope...
Status: RESOLVED WONTFIX
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-01-04 16:46 PST by Joseph Pecoraro
Modified: 2019-01-14 12:53 PST (History)
11 users (show)

See Also:


Attachments
[PATCH] Proposed Fix (3.74 KB, patch)
2019-01-04 16:53 PST, Joseph Pecoraro
mattbaker: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Joseph Pecoraro 2019-01-04 16:46:09 PST
Always buffer some console messages without requiring developerExtrasEnabled be enabled at log time
Comment 1 Joseph Pecoraro 2019-01-04 16:49:08 PST
<rdar://problem/36593635>
Comment 2 Joseph Pecoraro 2019-01-04 16:53:09 PST
Created attachment 358397 [details]
[PATCH] Proposed Fix

I'd like to measure any performance impact from this.
Comment 3 Matt Baker 2019-01-04 16:58:38 PST
Comment on attachment 358397 [details]
[PATCH] Proposed Fix

r=me
Comment 4 Joseph Pecoraro 2019-01-14 12:53:41 PST
Comment on attachment 358397 [details]
[PATCH] Proposed Fix

Obsoleting this patch. It caused a performance regression on benchmarks so I think I'll take a different approach.