Bug 193160 - Web Inspector: Use save sheet instead of dialog where possible
Summary: Web Inspector: Use save sheet instead of dialog where possible
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Joseph Pecoraro
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-01-04 14:15 PST by Joseph Pecoraro
Modified: 2019-01-04 16:34 PST (History)
5 users (show)

See Also:

Attachments
[PATCH] Proposed Fix (3.83 KB, patch)
2019-01-04 14:16 PST, Joseph Pecoraro 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Joseph Pecoraro 2019-01-04 14:15:20 PST 
Use save sheet instead of dialog where possible

Steps to Reproduce:
1. Inspect this page
2. Show Network Tab
3. Reload the page
4. Dock inspector
5. Click "Export" in the toolbar
  => Shows Save Dialog, expected Sheet to drop down from Toolbar

Notes:
- We use a sheet for a windowed inspector but didn't for docked.
Comment 1 Joseph Pecoraro 2019-01-04 14:15:41 PST 
<rdar://problem/37399759>
Comment 2 Joseph Pecoraro 2019-01-04 14:16:24 PST 
Created attachment 358366 [details]
[PATCH] Proposed Fix
Comment 3 Devin Rousso 2019-01-04 15:21:13 PST 
Comment on attachment 358366 [details]
[PATCH] Proposed Fix

rs=me, nice fix :)
Comment 4 WebKit Commit Bot 2019-01-04 16:34:06 PST 
Comment on attachment 358366 [details]
[PATCH] Proposed Fix

Clearing flags on attachment: 358366

Committed r239647: <https://trac.webkit.org/changeset/239647>
Comment 5 WebKit Commit Bot 2019-01-04 16:34:08 PST 
All reviewed patches have been landed.  Closing bug.