Bug 193143 - Add support for toggling device orientation API support per site
Summary: Add support for toggling device orientation API support per site
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-01-04 08:56 PST by Chris Dumez
Modified: 2019-01-04 14:12 PST (History)
10 users (show)

See Also:

Attachments
Patch (27.28 KB, patch)
2019-01-04 08:59 PST, Chris Dumez 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2019-01-04 08:56:33 PST 
Add support for toggling device orientation API support per site.
Comment 1 Chris Dumez 2019-01-04 08:56:48 PST 
<rdar://problem/46605724>
Comment 2 Chris Dumez 2019-01-04 08:59:09 PST 
Created attachment 358321 [details]
Patch
Comment 3 EWS Watchlist 2019-01-04 09:04:22 PST 
Attachment 358321 [details] did not pass style-queue:


ERROR: Tools/TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:1040:  Multi-line string ("...") found.  This lint script doesn't do well with such strings, and may give bogus warnings.  They're ugly and unnecessary, and you should use concatenation instead".  [readability/multiline_string] [5]
ERROR: Tools/TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:1046:  Multi-line string ("...") found.  This lint script doesn't do well with such strings, and may give bogus warnings.  They're ugly and unnecessary, and you should use concatenation instead".  [readability/multiline_string] [5]
Total errors found: 2 in 21 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 4 Chris Dumez 2019-01-04 14:12:03 PST 
Comment on attachment 358321 [details]
Patch

Clearing flags on attachment: 358321

Committed r239639: <https://trac.webkit.org/changeset/239639>
Comment 5 Chris Dumez 2019-01-04 14:12:05 PST 
All reviewed patches have been landed.  Closing bug.