WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
193143
Add support for toggling device orientation API support per site
https://bugs.webkit.org/show_bug.cgi?id=193143
Summary
Add support for toggling device orientation API support per site
Chris Dumez
Reported
2019-01-04 08:56:33 PST
Add support for toggling device orientation API support per site.
Attachments
Patch
(27.28 KB, patch)
2019-01-04 08:59 PST
,
Chris Dumez
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Chris Dumez
Comment 1
2019-01-04 08:56:48 PST
<
rdar://problem/46605724
>
Chris Dumez
Comment 2
2019-01-04 08:59:09 PST
Created
attachment 358321
[details]
Patch
EWS Watchlist
Comment 3
2019-01-04 09:04:22 PST
Attachment 358321
[details]
did not pass style-queue: ERROR: Tools/TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:1040: Multi-line string ("...") found. This lint script doesn't do well with such strings, and may give bogus warnings. They're ugly and unnecessary, and you should use concatenation instead". [readability/multiline_string] [5] ERROR: Tools/TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:1046: Multi-line string ("...") found. This lint script doesn't do well with such strings, and may give bogus warnings. They're ugly and unnecessary, and you should use concatenation instead". [readability/multiline_string] [5] Total errors found: 2 in 21 files If any of these errors are false positives, please file a bug against check-webkit-style.
Chris Dumez
Comment 4
2019-01-04 14:12:03 PST
Comment on
attachment 358321
[details]
Patch Clearing flags on attachment: 358321 Committed
r239639
: <
https://trac.webkit.org/changeset/239639
>
Chris Dumez
Comment 5
2019-01-04 14:12:05 PST
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug