RESOLVED FIXED 193136
[GTK] install-dependencies should install python3-setuptools, libunistring-dev, bison, flex
https://bugs.webkit.org/show_bug.cgi?id=193136
Summary [GTK] install-dependencies should install python3-setuptools, libunistring-de...
Oriol Brufau
Reported 2019-01-04 03:57:33 PST
I tried to compile WebKitGTK+ in a new PC with Ubuntu 18.04 but Tools/Scripts/update-webkitgtk-libs failed because python3-setuptools, libunistring-dev, bison and flex were not installed. They should have been installed by Tools/gtk/install-dependencies.
Attachments
Patch (1.74 KB, patch)
2019-01-04 10:46 PST, Oriol Brufau
no flags
Patch (3.26 KB, patch)
2019-01-05 09:52 PST, Oriol Brufau
no flags
Oriol Brufau
Comment 1 2019-01-04 04:41:00 PST
Bison and Flex dependencies were removed in bug 193033
Oriol Brufau
Comment 2 2019-01-04 10:45:32 PST
More precisely, - python3-setuptools is needed for meson: python3 setup.py build --build-base WebKitBuild/DependenciesGTK/Build/meson-0.48.1 Traceback (most recent call last): File "setup.py", line 26, in <module> from setuptools import setup ModuleNotFoundError: No module named 'setuptools' Failed to build GTK+ port dependencies with jhbuild - libunistring-dev is needed for libpsl: WebKitBuild/DependenciesGTK/Source/libpsl-0.20.2/configure --prefix WebKitBuild/DependenciesGTK/Root --disable-Werror --disable-static --disable-gtk-doc checking for LIBIDN2... yes checking for library containing u8_tolower... no configure: error: You requested libidn2|libidn but libunistring is not installed. Failed to build GTK+ port dependencies with jhbuild - bison is needed for gstreamer: WebKitBuild/DependenciesGTK/Source/gstreamer-1.14.4/configure --prefix WebKitBuild/DependenciesGTK/Root --disable-Werror --disable-gtk-doc --disable-introspection --disable-examples --disable-tests --disable-static --disable-gtk-doc checking for bison... no configure: error: Could not find bison Failed to build GTK+ port dependencies with jhbuild - flex is also needed for gstreamer: WebKitBuild/DependenciesGTK/Source/gstreamer-1.14.4/configure --prefix WebKitBuild/DependenciesGTK/Root --disable-Werror --disable-gtk-doc --disable-introspection --disable-examples --disable-tests --disable-static --disable-gtk-doc checking for flex... no configure: error: Could not find flex Failed to build GTK+ port dependencies with jhbuild
Oriol Brufau
Comment 3 2019-01-04 10:46:42 PST
Oriol Brufau
Comment 4 2019-01-04 10:54:27 PST
Not sure if I should also add the packages for brew, pacman and dnf.
Michael Catanzaro
Comment 5 2019-01-05 09:34:12 PST
You need to add them for Arch and Fedora, yes. You can ignore brew because (a) it's very different from Linux and probably requires specialized expertise to enable, and (b) WebKitGTK+ hasn't been buildable on Mac in a couple years AFAIK.
Oriol Brufau
Comment 6 2019-01-05 09:52:52 PST
WebKit Commit Bot
Comment 7 2019-01-05 17:19:11 PST
Comment on attachment 358439 [details] Patch Clearing flags on attachment: 358439 Committed r239660: <https://trac.webkit.org/changeset/239660>
WebKit Commit Bot
Comment 8 2019-01-05 17:19:12 PST
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 9 2019-01-05 17:21:30 PST
Note You need to log in before you can comment on or make changes to this bug.