Bug 193136 - [GTK] install-dependencies should install python3-setuptools, libunistring-dev, bison, flex
Summary: [GTK] install-dependencies should install python3-setuptools, libunistring-de...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Oriol Brufau
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-01-04 03:57 PST by Oriol Brufau
Modified: 2019-01-05 17:21 PST (History)
9 users (show)

See Also:

Attachments
Patch (1.74 KB, patch)
2019-01-04 10:46 PST, Oriol Brufau 		no flags Details | Formatted Diff | Diff
Patch (3.26 KB, patch)
2019-01-05 09:52 PST, Oriol Brufau 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Oriol Brufau 2019-01-04 03:57:33 PST 
I tried to compile WebKitGTK+ in a new PC with Ubuntu 18.04 but Tools/Scripts/update-webkitgtk-libs failed because python3-setuptools, libunistring-dev, bison and flex were not installed.
They should have been installed by Tools/gtk/install-dependencies.
Comment 1 Oriol Brufau 2019-01-04 04:41:00 PST 
Bison and Flex dependencies were removed in bug 193033
Comment 2 Oriol Brufau 2019-01-04 10:45:32 PST 
More precisely,

 - python3-setuptools is needed for meson:

    python3 setup.py build --build-base WebKitBuild/DependenciesGTK/Build/meson-0.48.1
    Traceback (most recent call last):
      File "setup.py", line 26, in <module>
        from setuptools import setup
    ModuleNotFoundError: No module named 'setuptools'
    Failed to build GTK+ port dependencies with jhbuild

 - libunistring-dev is needed for libpsl:

    WebKitBuild/DependenciesGTK/Source/libpsl-0.20.2/configure --prefix WebKitBuild/DependenciesGTK/Root --disable-Werror --disable-static --disable-gtk-doc
    checking for LIBIDN2... yes
    checking for library containing u8_tolower... no
    configure: error: You requested libidn2|libidn but libunistring is not installed.
    Failed to build GTK+ port dependencies with jhbuild

 - bison is needed for gstreamer:

    WebKitBuild/DependenciesGTK/Source/gstreamer-1.14.4/configure --prefix WebKitBuild/DependenciesGTK/Root --disable-Werror --disable-gtk-doc --disable-introspection --disable-examples --disable-tests --disable-static --disable-gtk-doc
    checking for bison... no
    configure: error: Could not find bison
    Failed to build GTK+ port dependencies with jhbuild

 - flex is also needed for gstreamer:

    WebKitBuild/DependenciesGTK/Source/gstreamer-1.14.4/configure --prefix WebKitBuild/DependenciesGTK/Root --disable-Werror --disable-gtk-doc --disable-introspection --disable-examples --disable-tests --disable-static --disable-gtk-doc
    checking for flex... no
    configure: error: Could not find flex
    Failed to build GTK+ port dependencies with jhbuild
Comment 3 Oriol Brufau 2019-01-04 10:46:42 PST 
Created attachment 358335 [details]
Patch
Comment 4 Oriol Brufau 2019-01-04 10:54:27 PST 
Not sure if I should also add the packages for brew, pacman and dnf.
Comment 5 Michael Catanzaro 2019-01-05 09:34:12 PST 
You need to add them for Arch and Fedora, yes.

You can ignore brew because (a) it's very different from Linux and probably requires specialized expertise to enable, and (b) WebKitGTK+ hasn't been buildable on Mac in a couple years AFAIK.
Comment 6 Oriol Brufau 2019-01-05 09:52:52 PST 
Created attachment 358439 [details]
Patch
Comment 7 WebKit Commit Bot 2019-01-05 17:19:11 PST 
Comment on attachment 358439 [details]
Patch

Clearing flags on attachment: 358439

Committed r239660: <https://trac.webkit.org/changeset/239660>
Comment 8 WebKit Commit Bot 2019-01-05 17:19:12 PST 
All reviewed patches have been landed.  Closing bug.
Comment 9 Radar WebKit Bug Importer 2019-01-05 17:21:30 PST 
<rdar://problem/47068948>