Bug 193129 - [Cocoa] Merge WebEditCommandProxy::nameForEditAction and undoNameForEditAction into a single function
Summary: [Cocoa] Merge WebEditCommandProxy::nameForEditAction and undoNameForEditActio...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: HTML Editing (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Wenson Hsieh
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-01-03 16:38 PST by Wenson Hsieh
Modified: 2019-01-04 11:59 PST (History)
7 users (show)

See Also:

Attachments
Patch (37.00 KB, patch)
2019-01-03 18:46 PST, Wenson Hsieh 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Wenson Hsieh 2019-01-03 16:38:07 PST 
As their corresponding FIXMEs state, these functions are nearly identical, and this logic should be shared.
Comment 1 Wenson Hsieh 2019-01-03 18:46:46 PST 
Created attachment 358300 [details]
Patch
Comment 2 WebKit Commit Bot 2019-01-04 11:57:00 PST 
Comment on attachment 358300 [details]
Patch

Clearing flags on attachment: 358300

Committed r239627: <https://trac.webkit.org/changeset/239627>
Comment 3 WebKit Commit Bot 2019-01-04 11:57:01 PST 
All reviewed patches have been landed.  Closing bug.
Comment 4 Radar WebKit Bug Importer 2019-01-04 11:59:04 PST 
<rdar://problem/47053815>