Bug 193121 - Bring back presentingApplicationPID
Summary: Bring back presentingApplicationPID
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Keith Rollin
Keywords: InRadar
Depends on:
Reported: 2019-01-03 12:49 PST by Keith Rollin
Modified: 2019-01-04 11:02 PST (History)
3 users (show)

See Also:

Patch (10.23 KB, patch)
2019-01-03 16:22 PST, Keith Rollin
no flags Details | Formatted Diff | Diff
Fix windows build. (10.24 KB, patch)
2019-01-03 17:04 PST, Keith Rollin
no flags Details | Formatted Diff | Diff
Oh, let's be generous ... fix *all* the builds. (10.42 KB, patch)
2019-01-03 17:16 PST, Keith Rollin
no flags Details | Formatted Diff | Diff
Patch (10.73 KB, patch)
2019-01-04 10:42 PST, Keith Rollin
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Keith Rollin 2019-01-03 12:49:20 PST
Bug 192961 removes presentingApplicationPID from NetworkProcessCreationParameters because it was (a) stored in some global state, the use of which is being minimized, and (b) it was largely unused. However, it was actually still being used in some useful logging in order to tie together child processes with their parent process. Re-introduce this value to NetworkProcessCreationParameters so that we can log it. But, this time, just use it locally instead of storing it in some global state for later retrieval.

Make a similar change to WebContentProcess for consistency purposes.
Comment 1 Radar WebKit Bug Importer 2019-01-03 12:49:35 PST
Comment 2 Keith Rollin 2019-01-03 13:28:15 PST
Actually, it sounds like the plans are for a Network Process to possibly have different parents, not necessarily just the one that actually created it. Therefore, instead of establishing a parent PID just once at startup, pass it in on every resource load request.
Comment 3 Keith Rollin 2019-01-03 16:22:39 PST
Created attachment 358287 [details]
Comment 4 Keith Rollin 2019-01-03 17:04:04 PST
Created attachment 358292 [details]
Fix windows build.
Comment 5 Keith Rollin 2019-01-03 17:16:16 PST
Created attachment 358293 [details]
Oh, let's be generous ... fix *all* the builds.
Comment 6 Alex Christensen 2019-01-04 10:23:54 PST
Comment on attachment 358293 [details]
Oh, let's be generous ... fix *all* the builds.

View in context: https://bugs.webkit.org/attachment.cgi?id=358293&action=review

> Source/WebKit/WebProcess/Network/WebLoaderStrategy.cpp:271
> +    loadParameters.parentPID = getCurrentProcessID();

This would be the pid of the WebProcess.  Is this what you wanted?  presentingApplicationPID would be the pid of the UIProcess.
Comment 7 Keith Rollin 2019-01-04 10:32:44 PST
Oh, right.
Comment 8 Keith Rollin 2019-01-04 10:42:18 PST
Created attachment 358334 [details]
Comment 9 WebKit Commit Bot 2019-01-04 11:02:08 PST
Comment on attachment 358334 [details]

Clearing flags on attachment: 358334

Committed r239622: <https://trac.webkit.org/changeset/239622>
Comment 10 WebKit Commit Bot 2019-01-04 11:02:09 PST
All reviewed patches have been landed.  Closing bug.