Bug 193117 - [WPE][GTK] WEBKIT_WEB_PROCESS_CRASHED should not trigger on Ctrl+C
Summary: [WPE][GTK] WEBKIT_WEB_PROCESS_CRASHED should not trigger on Ctrl+C
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: WebKit Nightly Build
Hardware: PC Linux
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-01-03 11:50 PST by Michael Catanzaro
Modified: 2021-02-05 10:33 PST (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Catanzaro 2019-01-03 11:50:40 PST 
$ epiphany
^C
** (epiphany:2): WARNING **: 13:46:18.727: Web process crashed

** (epiphany:2): WARNING **: 13:46:18.727: Web process crashed

** (epiphany:2): WARNING **: 13:46:18.727: Web process crashed

** (epiphany:2): WARNING **: 13:46:18.727: Web process crashed

** (epiphany:2): WARNING **: 13:46:18.727: Web process crashed

SIGINT causes one "web process crashed" warning to print per open tab. It's because web-process-terminated is emitted with WEBKIT_WEB_PROCESS_CRASHED whenever WebKit's IPC socket is closed (SIGHUP) without checking the exit status of the child process. We should really add a new WebKitWebProcessTerminationReason to account for stuff like this. SIGINT is not a crash, nor is SIGTERM or SIGKILL. Crashes are for SIGSEGV, SIGABRT, SIGILL, SIGBUS, etc.