RESOLVED FIXED 19311
On Mac, no way to differentiate Apple port from others in build scripts 
https://bugs.webkit.org/show_bug.cgi?id=19311
Summary On Mac, no way to differentiate Apple port from others in build scripts
Kevin Ollivier
Reported 2008-05-29 10:46:31 PDT
In r33446, a change was made to webkitdirs.pm that removed the isDarwin() check and changed isOSX() to behave like isDarwin(). However, isOSX() has always been used for code intended only for the Apple port, not other ports running on OS X, so now ports using build-webkit get the properties/settings intended for the Apple port.
Attachments
Restore original behavior of isOSX() (1.53 KB, patch)
2008-05-29 10:47 PDT, Kevin Ollivier 		darin: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Kevin Ollivier
Comment 1 2008-05-29 10:47:16 PDT
Created attachment 21415 [details] Restore original behavior of isOSX()
Darin Adler
Comment 2 2008-05-29 10:57:47 PDT
Comment on attachment 21415 [details] Restore original behavior of isOSX() Seems fine. Although I would probably use a different phrase from "Apple port". Please don't check in the double-ChangeLog entry.
Kevin Ollivier
Comment 3 2008-05-29 11:04:11 PDT
landed in r34206, thanks! :)
Note You need to log in before you can comment on or make changes to this bug.