Bug 193102 - [ews-build] Check patch relevance before applying the patch
Summary: [ews-build] Check patch relevance before applying the patch
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Aakash Jain
Keywords: InRadar
Depends on:
Reported: 2019-01-03 03:06 PST by Aakash Jain
Modified: 2019-01-04 10:03 PST (History)
7 users (show)

See Also:

Proposed patch (3.08 KB, patch)
2019-01-03 03:12 PST, Aakash Jain
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Aakash Jain 2019-01-03 03:06:38 PST
We should run the CheckPatchRelevance step before applying the patch. CheckPatchRelevance is very quick, usually less than a second, While applying the patch seems to take about half a minute (since it involve cleaning up any previous change, updating to ToT and then applying the patch).

For queues like WebKitPy-Tests where very little percentage of patches are actually relevant, it is a waste of time to apply the patch and then discover that the patch doesn't needs to be processed in the first place. Therefore checking the patch relevance should be one of the very first step.
Comment 1 Aakash Jain 2019-01-03 03:12:16 PST
Created attachment 358248 [details]
Proposed patch
Comment 2 EWS Watchlist 2019-01-03 03:15:06 PST Comment hidden (obsolete)
Comment 3 WebKit Commit Bot 2019-01-04 10:00:10 PST
Comment on attachment 358248 [details]
Proposed patch

Clearing flags on attachment: 358248

Committed r239616: <https://trac.webkit.org/changeset/239616>
Comment 4 WebKit Commit Bot 2019-01-04 10:00:11 PST
All reviewed patches have been landed.  Closing bug.
Comment 5 Radar WebKit Bug Importer 2019-01-04 10:03:41 PST