Bug 193095 - REGRESSION (r239306): Don't disable font smoothing in transparent layers on macOS Mojave and later
Summary: REGRESSION (r239306): Don't disable font smoothing in transparent layers on m...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Text (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Simon Fraser (smfr)
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-01-02 17:17 PST by Simon Fraser (smfr)
Modified: 2019-01-03 08:03 PST (History)
7 users (show)

See Also:

Attachments
Testcase (6.67 KB, text/html)
2019-01-02 17:17 PST, Simon Fraser (smfr) 		no flags Details
Patch (9.24 KB, patch)
2019-01-02 20:54 PST, Simon Fraser (smfr) 		zalan: review+
ews-watchlist: commit-queue-
Details | Formatted Diff | Diff
Archive of layout-test-results from ews104 for mac-sierra-wk2 (3.23 MB, application/zip)
2019-01-02 22:06 PST, EWS Watchlist 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Fraser (smfr) 2019-01-02 17:17:16 PST 
Created attachment 358227 [details]
Testcase

macOS Mojave no longer uses subpixel antialiasing, so there should be no need to choose different font rendering settings for smoothing/antialiasing when rendering in transparent vs. opaque layers. Indeed, we're still triggering visual differences when we don't need to.
Comment 1 Radar WebKit Bug Importer 2019-01-02 17:17:50 PST 
<rdar://problem/47014944>
Comment 2 Simon Fraser (smfr) 2019-01-02 20:20:21 PST 
I think this regressed with r239306, because now PlatformCALayer::drawLayerContents() turns off smoothing.
Comment 3 Simon Fraser (smfr) 2019-01-02 20:54:46 PST 
Created attachment 358244 [details]
Patch
Comment 4 EWS Watchlist 2019-01-02 22:06:54 PST 
Comment on attachment 358244 [details]
Patch

Attachment 358244 [details] did not pass mac-wk2-ews (mac-wk2):
Output: https://webkit-queues.webkit.org/results/10612519

New failing tests:
compositing/contents-format/subpixel-antialiased-text.html
Comment 5 EWS Watchlist 2019-01-02 22:06:56 PST 
Created attachment 358245 [details]
Archive of layout-test-results from ews104 for mac-sierra-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews104  Port: mac-sierra-wk2  Platform: Mac OS X 10.12.6
Comment 6 Simon Fraser (smfr) 2019-01-03 08:03:47 PST 
https://trac.webkit.org/changeset/239591/webkit