Bug 193090 - IndexedDB: When deleting databases, some open databases might be missed
Summary: IndexedDB: When deleting databases, some open databases might be missed
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Sihui Liu
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-01-02 14:52 PST by Sihui Liu
Modified: 2019-01-14 16:20 PST (History)
6 users (show)

See Also:

Attachments
patch (2.37 KB, patch)
2019-01-02 14:58 PST, Sihui Liu 		no flags Details | Formatted Diff | Diff
Patch for landing (2.55 KB, patch)
2019-01-14 15:40 PST, Sihui Liu 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Sihui Liu 2019-01-02 14:52:38 PST 
Currently we only close databases which have open database connections before deleting file.
Comment 1 Sihui Liu 2019-01-02 14:58:59 PST 
Created attachment 358210 [details]
patch
Comment 2 Brady Eidson 2019-01-11 09:22:05 PST 
Comment on attachment 358210 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=358210&action=review

> Source/WebCore/ChangeLog:3
> +        IndexedDB: files should be deleted after databases being opened are closed

This was also unclear to me.

Maybe "When deleting databases, some open databases might be missed"

> Source/WebCore/ChangeLog:8
> +        We should close all open databases instead of databases from open database connections, because database thread 

"We should close all databases with an open backing store instead of looking at which ones have an open database connection.
This is because a database might be in the process of getting a backing store before its connection has been created"
Comment 3 Sihui Liu 2019-01-14 15:40:47 PST 
Created attachment 359085 [details]
Patch for landing
Comment 4 WebKit Commit Bot 2019-01-14 16:19:23 PST 
Comment on attachment 359085 [details]
Patch for landing

Clearing flags on attachment: 359085

Committed r239960: <https://trac.webkit.org/changeset/239960>
Comment 5 WebKit Commit Bot 2019-01-14 16:19:24 PST 
All reviewed patches have been landed.  Closing bug.
Comment 6 Radar WebKit Bug Importer 2019-01-14 16:20:35 PST 
<rdar://problem/47269748>