Bug 193087 - Fix resourcetimingbufferfull bubbles attribute
Summary: Fix resourcetimingbufferfull bubbles attribute
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-01-02 12:39 PST by cvazac
Modified: 2019-01-02 15:43 PST (History)
6 users (show)

See Also:

Attachments
Patch (1.49 KB, patch)
2019-01-02 12:41 PST, cvazac 		no flags Details | Formatted Diff | Diff
Patch (1.64 KB, patch)
2019-01-02 12:53 PST, cvazac 		no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews102 for mac-sierra (2.43 MB, application/zip)
2019-01-02 13:44 PST, EWS Watchlist 		no flags Details
Archive of layout-test-results from ews104 for mac-sierra-wk2 (4.17 MB, application/zip)
2019-01-02 13:55 PST, EWS Watchlist 		no flags Details
Patch (3.21 KB, patch)
2019-01-02 14:12 PST, cvazac 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description cvazac 2019-01-02 12:39:59 PST 
Fix resourcetimingbufferfull bubbles aatribute
Comment 1 cvazac 2019-01-02 12:41:15 PST 
Created attachment 358195 [details]
Patch
Comment 2 EWS Watchlist 2019-01-02 12:43:18 PST 
Attachment 358195 [details] did not pass style-queue:


ERROR: Source/WebCore/ChangeLog:8:  You should remove the 'No new tests' and either add and list tests, or explain why no new tests were possible.  [changelog/nonewtests] [5]
Total errors found: 1 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 cvazac 2019-01-02 12:53:38 PST 
Created attachment 358196 [details]
Patch
Comment 4 cvazac 2019-01-02 12:55:01 PST 
Per spec change [1], the `bubbles` attribute on `resourcetimingbufferfull` events should no longer be set to `true` [2].

[1] https://github.com/w3c/resource-timing/pull/168
[2] https://github.com/w3c/resource-timing/pull/168/files#diff-eacf331f0ffc35d4b482f1d15a887d3bL848
Comment 5 EWS Watchlist 2019-01-02 13:44:46 PST 
Comment on attachment 358196 [details]
Patch

Attachment 358196 [details] did not pass mac-ews (mac):
Output: https://webkit-queues.webkit.org/results/10607657

New failing tests:
http/wpt/resource-timing/rt-performance-extensions.worker.html
http/wpt/resource-timing/rt-performance-extensions.html
Comment 6 EWS Watchlist 2019-01-02 13:44:53 PST 
Created attachment 358200 [details]
Archive of layout-test-results from ews102 for mac-sierra

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews102  Port: mac-sierra  Platform: Mac OS X 10.12.6
Comment 7 EWS Watchlist 2019-01-02 13:55:19 PST 
Comment on attachment 358196 [details]
Patch

Attachment 358196 [details] did not pass mac-wk2-ews (mac-wk2):
Output: https://webkit-queues.webkit.org/results/10607696

New failing tests:
http/wpt/resource-timing/rt-performance-extensions.worker.html
http/wpt/resource-timing/rt-performance-extensions.html
Comment 8 EWS Watchlist 2019-01-02 13:55:21 PST 
Created attachment 358201 [details]
Archive of layout-test-results from ews104 for mac-sierra-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews104  Port: mac-sierra-wk2  Platform: Mac OS X 10.12.6
Comment 9 cvazac 2019-01-02 14:12:16 PST 
Created attachment 358203 [details]
Patch
Comment 10 Chris Dumez 2019-01-02 15:16:03 PST 
Comment on attachment 358203 [details]
Patch

r=me
Comment 11 WebKit Commit Bot 2019-01-02 15:42:04 PST 
Comment on attachment 358203 [details]
Patch

Clearing flags on attachment: 358203

Committed r239579: <https://trac.webkit.org/changeset/239579>
Comment 12 WebKit Commit Bot 2019-01-02 15:42:06 PST 
All reviewed patches have been landed.  Closing bug.
Comment 13 Radar WebKit Bug Importer 2019-01-02 15:43:26 PST 
<rdar://problem/47012889>