Bug 193086 - Allow WebContent process access to some drawing-related IOKit properties
Summary: Allow WebContent process access to some drawing-related IOKit properties
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Brent Fulgham
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-01-02 12:26 PST by Brent Fulgham
Modified: 2019-01-11 19:40 PST (History)
5 users (show)

See Also:

Attachments
Patch Part 1 (3.41 KB, patch)
2019-01-02 12:37 PST, Brent Fulgham 		no flags Details | Formatted Diff | Diff
Patch (1.88 KB, patch)
2019-01-11 16:04 PST, Brent Fulgham 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Brent Fulgham 2019-01-02 12:26:28 PST 
Test run logging shows a number of drawing-related IOKit properties that are incorrectly denied by the current iOS sandbox. Denying these property checks can lead to reduced performance, drawing issues, and other bugs.

This patch allows the WebContent process on iOS to read these values.
Comment 1 Brent Fulgham 2019-01-02 12:26:47 PST 
<rdar://problem/46568088>
Comment 2 Brent Fulgham 2019-01-02 12:37:52 PST 
Created attachment 358194 [details]
Patch Part 1
Comment 3 WebKit Commit Bot 2019-01-02 15:50:32 PST 
Comment on attachment 358194 [details]
Patch Part 1

Clearing flags on attachment: 358194

Committed r239580: <https://trac.webkit.org/changeset/239580>
Comment 4 WebKit Commit Bot 2019-01-02 15:50:33 PST 
All reviewed patches have been landed.  Closing bug.
Comment 5 Brent Fulgham 2019-01-11 15:58:59 PST 
The sandbox regex wasn't quite right, and an additional property was needed. Creating a follow-up patch to fix this issue.
Comment 6 Brent Fulgham 2019-01-11 16:04:30 PST 
Created attachment 358959 [details]
Patch
Comment 7 WebKit Commit Bot 2019-01-11 19:40:17 PST 
Comment on attachment 358959 [details]
Patch

Clearing flags on attachment: 358959

Committed r239895: <https://trac.webkit.org/changeset/239895>
Comment 8 WebKit Commit Bot 2019-01-11 19:40:18 PST 
All reviewed patches have been landed.  Closing bug.