Bug 193082 - Remove logic handling DNT header during redirects
Summary: Remove logic handling DNT header during redirects
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Brent Fulgham
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-01-02 11:20 PST by Brent Fulgham
Modified: 2019-01-03 09:45 PST (History)
6 users (show)

See Also:

Attachments
Patch (2.78 KB, patch)
2019-01-02 11:23 PST, Brent Fulgham 		no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews125 for ios-simulator-wk2 (2.59 MB, application/zip)
2019-01-02 13:32 PST, EWS Watchlist 		no flags Details
Archive of layout-test-results from ews107 for mac-sierra-wk2 (3.96 MB, application/zip)
2019-01-02 13:34 PST, EWS Watchlist 		no flags Details
Patch (6.30 KB, patch)
2019-01-02 14:53 PST, Brent Fulgham 		no flags Details | Formatted Diff | Diff
Patch (9.93 KB, patch)
2019-01-03 08:51 PST, Brent Fulgham 		cdumez: review+
Details | Formatted Diff | Diff
Show Obsolete (4) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Brent Fulgham 2019-01-02 11:20:41 PST 
Don't bother passing DNT information during redirects. It's only ever used as a fingerprinting component.
Comment 1 Brent Fulgham 2019-01-02 11:21:47 PST 
<rdar://problem/45555965>
Comment 2 Brent Fulgham 2019-01-02 11:23:29 PST 
Created attachment 358190 [details]
Patch
Comment 3 EWS Watchlist 2019-01-02 13:32:15 PST 
Comment on attachment 358190 [details]
Patch

Attachment 358190 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: https://webkit-queues.webkit.org/results/10606969

New failing tests:
http/wpt/fetch/dnt-header-after-redirection.html
Comment 4 EWS Watchlist 2019-01-02 13:32:16 PST 
Created attachment 358198 [details]
Archive of layout-test-results from ews125 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews125  Port: ios-simulator-wk2  Platform: Mac OS X 10.13.6
Comment 5 EWS Watchlist 2019-01-02 13:33:59 PST 
Comment on attachment 358190 [details]
Patch

Attachment 358190 [details] did not pass mac-wk2-ews (mac-wk2):
Output: https://webkit-queues.webkit.org/results/10607487

New failing tests:
http/wpt/fetch/dnt-header-after-redirection.html
Comment 6 EWS Watchlist 2019-01-02 13:34:01 PST 
Created attachment 358199 [details]
Archive of layout-test-results from ews107 for mac-sierra-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews107  Port: mac-sierra-wk2  Platform: Mac OS X 10.12.6
Comment 7 Brent Fulgham 2019-01-02 14:26:06 PST 
Whoops! It looks like tests to make sure we include DNT in redirects started failing when I removed the DNT in redirects. :-)
Comment 8 Brent Fulgham 2019-01-02 14:53:51 PST 
Created attachment 358209 [details]
Patch
Comment 9 Chris Dumez 2019-01-02 16:23:20 PST 
Comment on attachment 358209 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=358209&action=review

> Source/WebKit/ChangeLog:18
> +2019-01-02  Brent Fulgham  <bfulgham@apple.com>

double change log.

> Source/WebKit/NetworkProcess/NetworkLoadChecker.cpp:90
>  void NetworkLoadChecker::prepareRedirectedRequest(ResourceRequest& request)

Can we drop the method that is now empty?
Comment 10 Brent Fulgham 2019-01-03 08:43:57 PST 
Comment on attachment 358209 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=358209&action=review

>> Source/WebKit/ChangeLog:18
>> +2019-01-02  Brent Fulgham  <bfulgham@apple.com>
> 
> double change log.

Doh! Fixing.

>> Source/WebKit/NetworkProcess/NetworkLoadChecker.cpp:90
>>  void NetworkLoadChecker::prepareRedirectedRequest(ResourceRequest& request)
> 
> Can we drop the method that is now empty?

Sure!
Comment 11 Brent Fulgham 2019-01-03 08:51:44 PST 
Created attachment 358256 [details]
Patch
Comment 12 Chris Dumez 2019-01-03 08:59:17 PST 
Comment on attachment 358256 [details]
Patch

r=me
Comment 13 Brent Fulgham 2019-01-03 09:45:02 PST 
Committed r239594: <https://trac.webkit.org/changeset/239594>