Bug 193068 – [GTK] Add missing autocleanups

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKitGTK

[Michael Catanzaro]

Add missing autocleanups

I wish we could switch to G_DECLARE_[FINAL,DERIVABLE]_TYPE so that we don't keep forgetting these, but I don't think it's possible without breaking ABI, and it would be insane to do with #ifdefs so we can't really do it for GTK+ 4 unless we drop GTK+ 3 at the same time... so we might be stuck with this legacy autocleanups file forever.

[Michael Catanzaro]

Created attachment 358177 [details]
Patch

[Michael Catanzaro]

(In reply to Michael Catanzaro from comment #0)
> so we might be stuck with this legacy autocleanups file forever.

FWIW I think it's reasonable to break ABI once every five years or so. This will cause zero problems for Linux distros as long as we don't make API changes. I want more padding in the WebKitWebView class struct anyway.

[Michael Catanzaro]

Er, I noticed WebKitOptionMenu is a GTK-specific type, and was surprised this didn't break the WPE EWS. But that's because it's a GTK-specific header. It looks like WPE does not have any autocleanups at all!

[Carlos Garcia Campos]

Comment on attachment 358177 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=358177&action=review

> Source/WebKit/ChangeLog:3
> +        [WPE][GTK] Add missing autocleanups

This is not affecting WPE

[Michael Catanzaro]

That's a problem in itself... how can we have failed to noticed that WPE does not offer autocleanups; that's awful. :( Adrian, why aren't you using these in cog?

[Michael Catanzaro]

Committed r239770: <https://trac.webkit.org/changeset/239770>