Bug 193064 - Test group results page from notification should not failed even for completed build type build requests.
Summary: Test group results page from notification should not failed even for complete...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: dewei_zhu
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-12-31 23:27 PST by dewei_zhu
Modified: 2019-01-18 17:05 PST (History)
2 users (show)

See Also:

Attachments
Patch (8.25 KB, patch)
2019-01-01 00:11 PST, dewei_zhu 		rniwa: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description dewei_zhu 2018-12-31 23:27:25 PST 
Test group results page from notification should not contain rows for build type build requests.
Comment 1 dewei_zhu 2019-01-01 00:11:37 PST 
Created attachment 358168 [details]
Patch
Comment 2 Ryosuke Niwa 2019-01-10 20:46:53 PST 
Comment on attachment 358168 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=358168&action=review

> Websites/perf.webkit.org/ChangeLog:3
> +        Test group results page from notification should not failed even for completed build type build requests.

Should probably revise this to say "Test group results notification should not say a build request to build had failed even when it had successfully completed"

> Websites/perf.webkit.org/tools/js/test-group-result-page.js:110
> +                    cellValue = 'failed';

Should be capitalized.
Comment 3 dewei_zhu 2019-01-18 15:28:12 PST 
<rdar://problem/43518845>
Comment 4 dewei_zhu 2019-01-18 17:05:50 PST 
Landed in r240182.