Bug 193055 - .ycm_extra_conf.py should handle XXXInlines.h
Summary: .ycm_extra_conf.py should handle XXXInlines.h
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Yusuke Suzuki
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-12-29 02:27 PST by Yusuke Suzuki
Modified: 2018-12-31 07:32 PST (History)
5 users (show)

See Also:

Attachments
Patch (3.03 KB, patch)
2018-12-29 02:30 PST, Yusuke Suzuki 		cgarcia: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Yusuke Suzuki 2018-12-29 02:27:20 PST 
.ycm_extra_conf.py should handle XXXInlines.h
Comment 1 Yusuke Suzuki 2018-12-29 02:30:00 PST 
Created attachment 358135 [details]
Patch
Comment 2 Carlos Garcia Campos 2018-12-31 05:50:05 PST 
Comment on attachment 358135 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=358135&action=review

> Tools/gtk/ycm_extra_conf.py:90
> +    else:

Does this work? this else: is not correctly indented. It can be removed, though, since previous line is a return.
Comment 3 Yusuke Suzuki 2018-12-31 07:30:40 PST 
(In reply to Carlos Garcia Campos from comment #2)
> Comment on attachment 358135 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=358135&action=review
> 
> > Tools/gtk/ycm_extra_conf.py:90
> > +    else:
> 
> Does this work? this else: is not correctly indented. It can be removed,
> though, since previous line is a return.

This is `else` for `for`, but yeah, we can just `return None` here. Fixed.
Comment 4 Yusuke Suzuki 2018-12-31 07:31:21 PST 
Committed r239567: <https://trac.webkit.org/changeset/239567>
Comment 5 Radar WebKit Bug Importer 2018-12-31 07:32:59 PST 
<rdar://problem/46987867>