[JSC] Identifier validity should be based on ID_Start / ID_Continue properties
Created attachment 358123 [details] Patch
Comment on attachment 358123 [details] Patch Attachment 358123 [details] did not pass mac-ews (mac): Output: https://webkit-queues.webkit.org/results/10571568 Number of test failures exceeded the failure limit.
Created attachment 358124 [details] Archive of layout-test-results from ews100 for mac-sierra The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews100 Port: mac-sierra Platform: Mac OS X 10.12.6
Comment on attachment 358123 [details] Patch Attachment 358123 [details] did not pass mac-wk2-ews (mac-wk2): Output: https://webkit-queues.webkit.org/results/10571593 Number of test failures exceeded the failure limit.
Created attachment 358125 [details] Archive of layout-test-results from ews106 for mac-sierra-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews106 Port: mac-sierra-wk2 Platform: Mac OS X 10.12.6
Comment on attachment 358123 [details] Patch Attachment 358123 [details] did not pass win-ews (win): Output: https://webkit-queues.webkit.org/results/10571689 New failing tests: sputnik/Unicode/Unicode_410/S7.6_A5.2_T6.html sputnik/Unicode/Unicode_218/S7.6_A5.3_T2.html sputnik/Unicode/Unicode_410/S7.6_A1.1_T6.html sputnik/Unicode/Unicode_218/S7.6_A5.2_T2.html sputnik/Unicode/Unicode_500/S7.6_A1.1_T6.html sputnik/Unicode/Unicode_320/S7.6_A1.1_T6.html sputnik/Unicode/Unicode_320/S7.6_A5.2_T9.html sputnik/Unicode/Unicode_218/S7.6_A5.2_T6.html sputnik/Unicode/Unicode_410/S7.6_A5.3_T2.html sputnik/Unicode/Unicode_500/S7.6_A3.2.html sputnik/Unicode/Unicode_510/S7.6_A5.2_T6.html sputnik/Unicode/Unicode_410/S7.6_A3.2.html sputnik/Unicode/Unicode_320/S7.6_A5.3_T2.html sputnik/Unicode/Unicode_510/S7.6_A5.2_T4.html sputnik/Unicode/Unicode_218/S7.6_A1.1_T2.html sputnik/Unicode/Unicode_510/S7.6_A1.1_T6.html sputnik/Unicode/Unicode_320/S7.6_A3.2.html sputnik/Unicode/Unicode_500/S7.6_A5.2_T6.html sputnik/Unicode/Unicode_510/S7.6_A1.1_T4.html sputnik/Unicode/Unicode_410/S7.6_A5.3_T1.html sputnik/Unicode/Unicode_320/S7.6_A5.2_T6.html sputnik/Unicode/Unicode_500/S7.6_A3.1.html sputnik/Unicode/Unicode_500/S7.6_A5.3_T2.html sputnik/Unicode/Unicode_320/S7.6_A5.3_T1.html sputnik/Unicode/Unicode_320/S7.6_A3.1.html sputnik/Unicode/Unicode_218/S7.6_A5.3_T1.html sputnik/Unicode/Unicode_218/S7.6_A1.1_T6.html
Created attachment 358126 [details] Archive of layout-test-results from ews200 for win-future The attached test failures were seen while running run-webkit-tests on the win-ews. Bot: ews200 Port: win-future Platform: CYGWIN_NT-6.1-2.9.0-0.318-5-3-x86_64-64bit
Comment on attachment 358123 [details] Patch Attachment 358123 [details] did not pass mac-debug-ews (mac): Output: https://webkit-queues.webkit.org/results/10571607 Number of test failures exceeded the failure limit.
Created attachment 358127 [details] Archive of layout-test-results from ews112 for mac-sierra The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews112 Port: mac-sierra Platform: Mac OS X 10.12.6
Comment on attachment 358123 [details] Patch Attachment 358123 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: https://webkit-queues.webkit.org/results/10571668 Number of test failures exceeded the failure limit.
Created attachment 358128 [details] Archive of layout-test-results from ews121 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews121 Port: ios-simulator-wk2 Platform: Mac OS X 10.13.6
Created attachment 358134 [details] Patch
Could you ensure that this patch does not cause perf regression by Octane/CodeLoad?
Use run-jsc-benchmarks w/ Octane
Before After encrypt 0.16460+-0.00032 0.16435+-0.00154 decrypt 3.29525+-0.01817 ? 3.29565+-0.02666 ? deltablue x2 0.12919+-0.01639 ? 0.14072+-0.01554 ? might be 1.0893x slower earley 0.28898+-0.00391 0.28864+-0.00190 boyer 4.64579+-0.25275 ? 4.79528+-0.07162 ? might be 1.0322x slower navier-stokes x2 5.15525+-0.02930 ? 5.17400+-0.02981 ? raytrace x2 0.95944+-0.00448 ? 0.96148+-0.01091 ? richards x2 0.09460+-0.00215 0.09414+-0.00064 splay x2 0.26329+-0.01758 0.26018+-0.02029 might be 1.0120x faster regexp x2 17.43834+-0.67396 ? 17.45390+-0.34534 ? pdfjs x2 36.92053+-0.35143 ? 37.09441+-0.33873 ? mandreel x2 44.16759+-0.26156 44.14174+-0.15724 gbemu x2 31.62589+-0.40317 ? 31.70962+-0.23330 ? closure 0.52461+-0.00206 ? 0.52802+-0.01309 ? jquery 7.05201+-0.07046 7.01159+-0.05275 box2d x2 8.74566+-0.17569 ? 8.86146+-0.06800 ? might be 1.0132x slower zlib x2 311.75838+-2.98803 ? 312.19987+-0.37864 ? typescript x2 652.24139+-13.43518 650.57477+-17.68439 splay-latency 2.29484+-0.57967 2.16220+-0.33481 might be 1.0613x faster <geometric> 4.97333+-0.05942 ? 4.99993+-0.07612 ? might be 1.0053x slower
Comment on attachment 358134 [details] Patch r=me. Before landing, please ensure that perf regression does not happen in UChar path by adding some non latin characters in Octane jquery/closure and ensure Lexer<UChar> is used at that time (instead of Lexer<LChar>.
(In reply to Yusuke Suzuki from comment #16) > Comment on attachment 358134 [details] > Patch > > r=me. Before landing, please ensure that perf regression does not happen in > UChar path by adding some non latin characters in Octane jquery/closure and > ensure Lexer<UChar> is used at that time (instead of Lexer<LChar>. Sure -- if I scatter six non-Latin variable declarations among the source of each, the results are similar: closure 0.55140+-0.02087 0.53967+-0.00117 might be 1.0217x faster jquery 7.33271+-0.43245 7.21572+-0.14073 might be 1.0162x faster
OK, cool. Nice work!
Comment on attachment 358134 [details] Patch Clearing flags on attachment: 358134 Committed r239559: <https://trac.webkit.org/changeset/239559>
All reviewed patches have been landed. Closing bug.
<rdar://problem/46982697>