Add ENABLE_UNIFIED_BUILDS option to cmake ports
Created attachment 358115 [details] Patch
Created attachment 358116 [details] Patch
Created attachment 358117 [details] Patch
Created attachment 358118 [details] Patch
Note that this patch itself does not fix the build failures with non-unified builds. This change allows us to generate non-unified compile_commands.json with CMake.
Shouldn't we name it ENABLE_ALLINONE_BUILD to match name of option which was available in the past?
Well it's not really ALLINONE
(In reply to Konstantin Tokarev from comment #6) > Shouldn't we name it ENABLE_ALLINONE_BUILD to match name of option which was > available in the past? Do we use ENABLE_UNIFIED_BUILDS option in practice in the past? I think this name is the most appropriate one to this functionality. So if it does not pose actual problems, I would like to use this name. If this poses the problem, the other name like USE_UNIFIED_BUILDS also sounds nice to me. But I think “All In One” is misleading since our unified builds bundle (typically) 8 source files to one source bundle, not bundling all the sources into one bundle.
(In reply to Michael Catanzaro from comment #7) > Well it's not really ALLINONE Ah, Michael was fast. My second comment was duplicate :P
Comment on attachment 358118 [details] Patch r=me Thank you so much for doing this! Can't wait to build without Unified Sources.
(In reply to Don Olmstead from comment #10) > Comment on attachment 358118 [details] > Patch > > r=me > > Thank you so much for doing this! Can't wait to build without Unified > Sources. :D This allows me to use YCM with fully enabled completions!
Committed r239561: <https://trac.webkit.org/changeset/239561>
<rdar://problem/46983277>
Will also be nice for integrating some clang tooling like tidy and IWYU. Next step might be to enable those and have it default to OFF when either are enabled.