Bug 193041 – AX: String check: "Rule" does not reflect the meaning of the <hr> html tag

• Status: RESOLVED
• Resolution: FIXED
• Component: Accessibility

[chris fleizach]

EN suggested: line 

This should be the accessability role description for a horizontal rule <hr> in HTML 4.x. In HTML 5.0 since you can no longer edit certain aspects of it it is called a Thematic Break line. However, it is still represented by a horizontal line separating sections of a website.
The important and relevant part of “horizontal rule” is in fact … horizontal, rule being too generic to be relevant in this case. 

More info:
https://www.w3schools.com/tags/tag_hr.asp
https://developer.mozilla.org/en-US/docs/Web/HTML/Element/hr
https://www.w3schools.com/howto/howto_css_style_hr.asp

-----------------------

I think the essence of both “Horizontal rule” and “Thematic break” are in their function of separation, regardless of their horizontal or thematic nature. Therefore, I think “separator” is an accurate way to describe <hr>, which is also specific enough to yield an authentic localization string (as opposed to the ambiguious “line” and “rule”).

[Radar WebKit Bug Importer]

<rdar://problem/46954090>

[chris fleizach]

Created attachment 358090 [details]
patch

[chris fleizach]

rdar://problem/46630975

[EWS Watchlist]

Comment on attachment 358090 [details]
patch

Attachment 358090 [details] did not pass mac-ews (mac):
Output: https://webkit-queues.webkit.org/results/10555419

New failing tests:
accessibility/roles-exposed.html

[EWS Watchlist]

Created attachment 358092 [details]
Archive of layout-test-results from ews103 for mac-sierra

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews103  Port: mac-sierra  Platform: Mac OS X 10.12.6

[EWS Watchlist]

Comment on attachment 358090 [details]
patch

Attachment 358090 [details] did not pass mac-wk2-ews (mac-wk2):
Output: https://webkit-queues.webkit.org/results/10555432

New failing tests:
accessibility/roles-exposed.html

[EWS Watchlist]

Created attachment 358094 [details]
Archive of layout-test-results from ews104 for mac-sierra-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews104  Port: mac-sierra-wk2  Platform: Mac OS X 10.12.6

[EWS Watchlist]

Comment on attachment 358090 [details]
patch

Attachment 358090 [details] did not pass mac-debug-ews (mac):
Output: https://webkit-queues.webkit.org/results/10555557

New failing tests:
accessibility/roles-exposed.html

[EWS Watchlist]

Created attachment 358096 [details]
Archive of layout-test-results from ews116 for mac-sierra

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews116  Port: mac-sierra  Platform: Mac OS X 10.12.6

[chris fleizach]

Created attachment 358100 [details]
patch

[EWS Watchlist]

Attachment 358100 [details] did not pass style-queue:


ERROR: LayoutTests/ChangeLog:10:  Need whitespace between colon and description  [changelog/filechangedescriptionwhitespace] [5]
Total errors found: 1 in 6 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[chris fleizach]

Created attachment 358101 [details]
patch

[chris fleizach]

Created attachment 358102 [details]
patch

[WebKit Commit Bot]

Comment on attachment 358102 [details]
patch

Clearing flags on attachment: 358102

Committed r239613: <https://trac.webkit.org/changeset/239613>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[James Craig]

<rdar://problem/46630975>