Bug 193007 - [WHLSL] Implement the NameResolver
Summary: [WHLSL] Implement the NameResolver
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebGPU (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Myles C. Maxfield
URL:
Keywords: InRadar
Depends on: 192826
Blocks:
  Show dependency treegraph
 
Reported: 2018-12-22 01:00 PST by Myles C. Maxfield
Modified: 2019-01-11 22:27 PST (History)
8 users (show)

See Also:


Attachments
Patch (38.61 KB, patch)
2018-12-22 01:01 PST, Myles C. Maxfield
no flags Details | Formatted Diff | Diff
Patch (45.64 KB, patch)
2018-12-22 03:15 PST, Myles C. Maxfield
no flags Details | Formatted Diff | Diff
Patch (162.81 KB, patch)
2018-12-31 17:41 PST, Myles C. Maxfield
no flags Details | Formatted Diff | Diff
Patch (164.30 KB, patch)
2018-12-31 22:07 PST, Myles C. Maxfield
no flags Details | Formatted Diff | Diff
Patch (170.30 KB, patch)
2018-12-31 23:03 PST, Myles C. Maxfield
no flags Details | Formatted Diff | Diff
Patch (233.09 KB, patch)
2019-01-01 00:41 PST, Myles C. Maxfield
no flags Details | Formatted Diff | Diff
Patch (32.69 KB, patch)
2019-01-11 00:24 PST, Myles C. Maxfield
no flags Details | Formatted Diff | Diff
Patch (69.65 KB, patch)
2019-01-11 10:41 PST, Myles C. Maxfield
no flags Details | Formatted Diff | Diff
Patch (68.63 KB, patch)
2019-01-11 11:50 PST, Myles C. Maxfield
no flags Details | Formatted Diff | Diff
Patch (68.88 KB, patch)
2019-01-11 12:33 PST, Myles C. Maxfield
dino: review+
Details | Formatted Diff | Diff
Patch for committing (71.55 KB, patch)
2019-01-11 19:53 PST, Myles C. Maxfield
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Myles C. Maxfield 2018-12-22 01:00:56 PST
Implement the NameResolver
Comment 1 Myles C. Maxfield 2018-12-22 01:01:29 PST
Created attachment 358021 [details]
Patch
Comment 2 Myles C. Maxfield 2018-12-22 03:15:59 PST
Created attachment 358022 [details]
Patch
Comment 3 Myles C. Maxfield 2018-12-31 17:41:23 PST
Created attachment 358157 [details]
Patch
Comment 4 Myles C. Maxfield 2018-12-31 22:07:32 PST
Created attachment 358164 [details]
Patch
Comment 5 Myles C. Maxfield 2018-12-31 23:03:50 PST
Created attachment 358167 [details]
Patch
Comment 6 Myles C. Maxfield 2019-01-01 00:41:14 PST
Created attachment 358169 [details]
Patch
Comment 7 Myles C. Maxfield 2019-01-11 00:24:05 PST
Created attachment 358883 [details]
Patch
Comment 8 Myles C. Maxfield 2019-01-11 10:41:09 PST
Created attachment 358908 [details]
Patch
Comment 9 Myles C. Maxfield 2019-01-11 11:50:27 PST
Created attachment 358922 [details]
Patch
Comment 10 Myles C. Maxfield 2019-01-11 12:18:38 PST
Comment on attachment 358922 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=358922&action=review

> Source/WebCore/Modules/webgpu/WHLSL/WHLSLProgram.h:47
>      bool append(AST::TypeDefinition&& typeDefinition)

#include "WHLSLNameContext.h"
Comment 11 Myles C. Maxfield 2019-01-11 12:33:23 PST
Created attachment 358928 [details]
Patch
Comment 12 Myles C. Maxfield 2019-01-11 19:53:52 PST
Created attachment 358977 [details]
Patch for committing
Comment 13 Myles C. Maxfield 2019-01-11 22:26:27 PST
Committed r239896: <https://trac.webkit.org/changeset/239896>
Comment 14 Radar WebKit Bug Importer 2019-01-11 22:27:29 PST
<rdar://problem/47229039>