Bug 193005 – [iOS] Suppress native selection behaviors when focusing a very small editable element

• Status: RESOLVED
• Resolution: FIXED
• Component: HTML Editing

[Wenson Hsieh]

<rdar://problem/46583527>

[Wenson Hsieh]

Created attachment 358019 [details]
Patch

[Wenson Hsieh]

Comment on attachment 358019 [details]
Patch

Thanks for the review!

It looks like a couple of layout tests are failing on EWS on iOS simulator, but they don't look related to this change:

• imported/w3c/web-platform-tests/service-workers/service-worker/register-default-scope.https.html
• fast/ruby/ruby-base-merge-block-children-crash-2.html

[WebKit Commit Bot]

Comment on attachment 358019 [details]
Patch

Clearing flags on attachment: 358019

Committed r239543: <https://trac.webkit.org/changeset/239543>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Wenson Hsieh]

(In reply to Wenson Hsieh from comment #2)
> Comment on attachment 358019 [details]
> Patch
> 
> Thanks for the review!
> 
> It looks like a couple of layout tests are failing on EWS on iOS simulator,
> but they don't look related to this change:
> 
> • imported/w3c/web-platform-tests/service-workers/service-worker/register-default-scope.https.html
> • fast/ruby/ruby-base-merge-block-children-crash-2.html

I take that back, the second test here (ruby-base-merge-block-children-crash-2.html) was definitely failing because of my change. The problem is that my patch doesn't handle integer overflow when computing focused element rect area, so we will crash if focus moves to an editable element with a gigantic bounding rect. I've put up a fix for this in <https://bugs.webkit.org/show_bug.cgi?id=193015>.

As an aside, I'm a bit confused why the ios-sim EWS bot didn't complain about this and instead just kept on retrying the patch over and over again...