Bug 192999 - Web Inspector: Styles Redesign: remove unused CSS style icons
Summary: Web Inspector: Styles Redesign: remove unused CSS style icons
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Devin Rousso
URL:
Keywords: InRadar
Depends on:
Blocks: 177471
  Show dependency tree / graph
 
Reported: 2018-12-21 15:57 PST by Devin Rousso
Modified: 2018-12-21 16:39 PST (History)
6 users (show)

See Also:

Attachments
Patch (23.98 KB, patch)
2018-12-21 16:00 PST, Devin Rousso 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Devin Rousso 2018-12-21 15:57:39 PST 
The following icons are no longer needed with the move to the spreadsheet style editor:
 - UserInterface/Images/StyleRule.svg
 - UserInterface/Images/StyleRuleInheritedElement.svg
 - UserInterface/Images/StyleRulePseudoElement.svg

The CSS files that used these icons can also be removed:
 - UserInterface/Views/StyleRuleIcons.css
Comment 1 Radar WebKit Bug Importer 2018-12-21 15:57:59 PST 
<rdar://problem/46912094>
Comment 2 Devin Rousso 2018-12-21 16:00:21 PST 
Created attachment 357997 [details]
Patch
Comment 3 Nikita Vasilyev 2018-12-21 16:05:14 PST 
They are indeed no longer used. Good cleanup! I'd r+.
Comment 4 Matt Baker 2018-12-21 16:12:34 PST 
Comment on attachment 357997 [details]
Patch

Thanks for breaking this out.
Comment 5 WebKit Commit Bot 2018-12-21 16:39:13 PST 
Comment on attachment 357997 [details]
Patch

Clearing flags on attachment: 357997

Committed r239530: <https://trac.webkit.org/changeset/239530>
Comment 6 WebKit Commit Bot 2018-12-21 16:39:14 PST 
All reviewed patches have been landed.  Closing bug.