RESOLVED FIXED 192986
[HarfBuzz] Width not correctly reported as 0 for zero font size
https://bugs.webkit.org/show_bug.cgi?id=192986
Summary [HarfBuzz] Width not correctly reported as 0 for zero font size
Carlos Garcia Campos
Reported 2018-12-21 10:38:36 PST
This caused test fast/text/font-size-zero.html (ans likely some others) to fail since we started to use complex text for GTK+ layout tests.
Attachments
Patch (1.58 KB, patch)
2018-12-21 10:40 PST, Carlos Garcia Campos
mcatanzaro: review+
Carlos Garcia Campos
Comment 1 2018-12-21 10:40:35 PST
Michael Catanzaro
Comment 2 2018-12-21 11:30:48 PST
Comment on attachment 357958 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=357958&action=review > Source/WebCore/ChangeLog:11 > + (WebCore::ComplexTextController::ComplexTextRun::ComplexTextRun): Use empty advances for glyps when the font glyphs
Carlos Garcia Campos
Comment 3 2018-12-22 04:34:05 PST
Radar WebKit Bug Importer
Comment 4 2018-12-22 04:35:26 PST
Michael Catanzaro
Comment 5 2019-01-20 19:09:57 PST
I'm updating this expectation (assuming the change in expectation is correct): --- /home/slave/webkitgtk/gtk-linux-64-release-tests/build/layout-test-results/svg/text/font-size-below-point-five-expected.txt +++ /home/slave/webkitgtk/gtk-linux-64-release-tests/build/layout-test-results/svg/text/font-size-below-point-five-actual.txt @@ -30,7 +30,6 @@ chunk 1 text run 1 at (35.63,10.00) startOffset 0 endOffset 1 width 4.06: " " RenderSVGTSpan {tspan} at (0,0) size 0x1 RenderSVGInlineText {#text} at (-10,4) size 0x0 - chunk 1 text run 1 at (39.69,10.00) startOffset 0 endOffset 1 width 0.31: "6" RenderSVGInlineText {#text} at (0,0) size 0x0 RenderSVGText {text} at (63,42) size 124x10 contains 1 chunk(s) RenderSVGInlineText {#text} at (0,0) size 124x9
Note You need to log in before you can comment on or make changes to this bug.