RESOLVED FIXED 192981
[JSC] Use appendUnbarriered for cached own keys 
https://bugs.webkit.org/show_bug.cgi?id=192981
Summary [JSC] Use appendUnbarriered for cached own keys
Yusuke Suzuki
Reported 2018-12-21 06:46:22 PST
[JSC] Use appendUnbarriered for cached own keys
Attachments
Patch (2.00 KB, patch)
2018-12-21 06:49 PST, Yusuke Suzuki 		saam: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Yusuke Suzuki
Comment 1 2018-12-21 06:49:00 PST
Created attachment 357941 [details] Patch
Saam Barati
Comment 2 2018-12-21 10:11:51 PST
Comment on attachment 357941 [details] Patch r=me
Saam Barati
Comment 3 2018-12-21 10:12:32 PST
Comment on attachment 357941 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=357941&action=review > Source/JavaScriptCore/ChangeLog:8 > + It seems unlikely now, but m_cachedOwnKeys would be changed to sentinel after I think unlikely is the wrong wording. We never do this now, but might in the future.
Yusuke Suzuki
Comment 4 2018-12-21 10:14:33 PST
(In reply to Saam Barati from comment #3) > Comment on attachment 357941 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=357941&action=review > > > Source/JavaScriptCore/ChangeLog:8 > > + It seems unlikely now, but m_cachedOwnKeys would be changed to sentinel after > > I think unlikely is the wrong wording. We never do this now, but might in > the future. Yeah, fixed. Thanks :)
Yusuke Suzuki
Comment 5 2018-12-21 22:39:28 PST
Committed r239536: <https://trac.webkit.org/changeset/239536>
Radar WebKit Bug Importer
Comment 6 2018-12-21 22:40:25 PST
<rdar://problem/46916287>
Note You need to log in before you can comment on or make changes to this bug.