Bug 192981 - [JSC] Use appendUnbarriered for cached own keys
Summary: [JSC] Use appendUnbarriered for cached own keys
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Yusuke Suzuki
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-12-21 06:46 PST by Yusuke Suzuki
Modified: 2018-12-21 22:40 PST (History)
6 users (show)

See Also:

Attachments
Patch (2.00 KB, patch)
2018-12-21 06:49 PST, Yusuke Suzuki 		saam: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Yusuke Suzuki 2018-12-21 06:46:22 PST 
[JSC] Use appendUnbarriered for cached own keys
Comment 1 Yusuke Suzuki 2018-12-21 06:49:00 PST 
Created attachment 357941 [details]
Patch
Comment 2 Saam Barati 2018-12-21 10:11:51 PST 
Comment on attachment 357941 [details]
Patch

r=me
Comment 3 Saam Barati 2018-12-21 10:12:32 PST 
Comment on attachment 357941 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=357941&action=review

> Source/JavaScriptCore/ChangeLog:8
> +        It seems unlikely now, but m_cachedOwnKeys would be changed to sentinel after

I think unlikely is the wrong wording. We never do this now, but might in the future.
Comment 4 Yusuke Suzuki 2018-12-21 10:14:33 PST 
(In reply to Saam Barati from comment #3)
> Comment on attachment 357941 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=357941&action=review
> 
> > Source/JavaScriptCore/ChangeLog:8
> > +        It seems unlikely now, but m_cachedOwnKeys would be changed to sentinel after
> 
> I think unlikely is the wrong wording. We never do this now, but might in
> the future.

Yeah, fixed. Thanks :)
Comment 5 Yusuke Suzuki 2018-12-21 22:39:28 PST 
Committed r239536: <https://trac.webkit.org/changeset/239536>
Comment 6 Radar WebKit Bug Importer 2018-12-21 22:40:25 PST 
<rdar://problem/46916287>