Bug 192970 – [curl] Move cookiePersistentStorageFile from NetworkProcessCreationParameters to NetworkSessionCreationParameters

• Status: RESOLVED
• Resolution: FIXED
• Component: Platform

[Fujii Hironori]

[curl] Move cookiePersistentStorageFile from NetworkProcessCreationParameters to NetworkSessionCreationParameters

[webkit-dev] Reducing globals
https://lists.webkit.org/pipermail/webkit-dev/2018-December/030267.html

[Fujii Hironori]

Created attachment 357921 [details]
Patch

[Alex Christensen]

Comment on attachment 357921 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=357921&action=review

r=me.  Thanks

> Source/WebKit/NetworkProcess/curl/NetworkSessionCurl.cpp:43
> +        NetworkProcess::singleton().supplement<WebCookieManager>()->setCookiePersistentStorage(parameters.cookiePersistentStorageFile);

This is a great step in the right direction.  Thanks!  The next step would be to stop using the NetworkProcess::singleton() for this.

[Alex Christensen]

Comment on attachment 357921 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=357921&action=review

>> Source/WebKit/NetworkProcess/curl/NetworkSessionCurl.cpp:43
>> +        NetworkProcess::singleton().supplement<WebCookieManager>()->setCookiePersistentStorage(parameters.cookiePersistentStorageFile);
> 
> This is a great step in the right direction.  Thanks!  The next step would be to stop using the NetworkProcess::singleton() for this.

Instead, this should probably be a member of the NetworkSessionCurl or even better, the NetworkStorageSession.

[Fujii Hironori]

Comment on attachment 357921 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=357921&action=review

Thank you for the review.

>>> Source/WebKit/NetworkProcess/curl/NetworkSessionCurl.cpp:43
>>> +        NetworkProcess::singleton().supplement<WebCookieManager>()->setCookiePersistentStorage(parameters.cookiePersistentStorageFile);
>> 
>> This is a great step in the right direction.  Thanks!  The next step would be to stop using the NetworkProcess::singleton() for this.
> 
> Instead, this should probably be a member of the NetworkSessionCurl or even better, the NetworkStorageSession.

I get the idea. I will revise this patch.

[Fujii Hironori]

NetworkProcess::setNetworkProxySettings also should be removed?
https://trac.webkit.org/browser/webkit/trunk/Source/WebKit/NetworkProcess/NetworkProcess.h?rev=239474#L297

[Fujii Hironori]

Created attachment 358051 [details]
WIP Patch

[Alex Christensen]

Comment on attachment 358051 [details]
WIP Patch

Looks good to me.

[WebKit Commit Bot]

Comment on attachment 358051 [details]
WIP Patch

Clearing flags on attachment: 358051

Committed r239624: <https://trac.webkit.org/changeset/239624>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/47052236>