Bug 192968 – [WebKit][Win] Remove using namespace in the global scope

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit2

[Fujii Hironori]

[WebKit][Win] Remove using namespace in the global space

This is a sub task of Bug 192449.

https://webkit.org/code-style-guidelines/#using-position

[Fujii Hironori]

Created attachment 357916 [details]
Patch

[Ross Kirsling]

Comment on attachment 357916 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=357916&action=review

LGTM though this requires a WebKit reviewer.

> Source/WebKit/Shared/WebWheelEvent.cpp:32
> -namespace WebKit {    
> +namespace WebKit {
> +

Nit: This file should probably be dropped from the diff if we're only modifying whitespace.

[Ross Kirsling]

(In reply to Ross Kirsling from comment #2)
> Comment on attachment 357916 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=357916&action=review
> 
> LGTM though this requires a WebKit reviewer.

Er, "owner" not reviewer.

[Fujii Hironori]

Thanks Ross.
Added WK2 owners to Cc.

[Alex Christensen]

Comment on attachment 357916 [details]
Patch

Whitespace change is fine by me.

[Fujii Hironori]

Comment on attachment 357916 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=357916&action=review

>> Source/WebKit/Shared/WebWheelEvent.cpp:32
>> +
> 
> Nit: This file should probably be dropped from the diff if we're only modifying whitespace.

I want to remove the trailing space after '{' because it causes a trouble for my grepping script (Bug 192449 Comment 1). 😅

[Fujii Hironori]

Committed r239550: <https://trac.webkit.org/changeset/239550>

[Radar WebKit Bug Importer]

<rdar://problem/46937469>

[Ross Kirsling]

(In reply to Fujii Hironori from comment #6)
> Comment on attachment 357916 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=357916&action=review
> 
> >> Source/WebKit/Shared/WebWheelEvent.cpp:32
> >> +
> > 
> > Nit: This file should probably be dropped from the diff if we're only modifying whitespace.
> 
> I want to remove the trailing space after '{' because it causes a trouble
> for my grepping script (Bug 192449 Comment 1). 😅

Haha, I have no personal objection -- just wanted to be sensitive to "churn avoidance" concerns. :)